Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend EthChainSpec trait #10909

Closed
Tracked by #10744
mattsse opened this issue Sep 14, 2024 · 0 comments · Fixed by #11304
Closed
Tracked by #10744

Extend EthChainSpec trait #10909

mattsse opened this issue Sep 14, 2024 · 0 comments · Fixed by #11304
Assignees
Labels
A-sdk Related to reth's use as a library C-enhancement New feature or request

Comments

@mattsse
Copy link
Collaborator

mattsse commented Sep 14, 2024

in order to do #10751 we need to expand

pub trait EthChainSpec: Send + Sync + Unpin + Debug + 'static {

we can do something similar to:

pub trait EthereumHardforks: Hardforks {

and

pub trait OptimismHardforks: EthereumHardforks {

but for EthChainSpec

the EthChainSpec trait should include all functions of:

impl ChainSpec {

imo the best way to do this is

  • introduce the traits and impl for ChainSpec
  • then relax default types and replace with trait (gradually)
  • once we have that, we can finally separate ChainSpec into struct EthChainspec and OpChainSpec
  • then we can also finally get rid of the dyn hardforks stuff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sdk Related to reth's use as a library C-enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants