Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cached db handles access may panic (call get_dbi on more than one thread) #6922

Closed
1 task done
AtomicAzzaz opened this issue Mar 1, 2024 · 0 comments · Fixed by #6923
Closed
1 task done

Cached db handles access may panic (call get_dbi on more than one thread) #6922

AtomicAzzaz opened this issue Mar 1, 2024 · 0 comments · Fixed by #6923
Labels
A-db Related to the database C-bug An unexpected or incorrect behavior

Comments

@AtomicAzzaz
Copy link
Contributor

AtomicAzzaz commented Mar 1, 2024 •
edited
Loading

Describe the bug

#6750 Replaces a Mutex by OnceLock but as it is the OnceLock doesn't guarantee it's not set before the following unwrap is called.
I believe it may be set by another thread before as I got panics from here in my code.

Steps to reproduce

Make many db access in parallel I guess

Node logs

No response

Platform(s)

Linux (ARM)

What version/commit are you on?

7d6fb37

What database version are you on?

1

What type of node are you running?

Pruned with custom reth.toml config

What prune config do you use, if any?

No response

If you've built Reth from source, provide the full command you used

No response

Code of Conduct

  • I agree to follow the Code of Conduct
@AtomicAzzaz AtomicAzzaz added C-bug An unexpected or incorrect behavior S-needs-triage This issue needs to be labelled labels Mar 1, 2024
@rkrasiuk rkrasiuk added A-db Related to the database and removed S-needs-triage This issue needs to be labelled labels Mar 2, 2024
@rkrasiuk rkrasiuk linked a pull request Mar 2, 2024 that will close this issue
fix(db): race condition in Tx cached handles #6923
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-db Related to the database C-bug An unexpected or incorrect behavior
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(db): race condition in Tx cached handles paradigmxyz/reth
2 participants
@rkrasiuk @AtomicAzzaz