Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decrease default tracing permits #7004

Closed
mattsse opened this issue Mar 6, 2024 · 1 comment · Fixed by #7010
Closed

decrease default tracing permits #7004

mattsse opened this issue Mar 6, 2024 · 1 comment · Fixed by #7010
Assignees
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Mar 6, 2024

Describe the feature

The default tracing permits:

let _permit = self.acquire_trace_permit().await;

are too high. tracing is mostly cpu bound, so the default should be max(std::thread::available_parallelism() - x, 2) where x could be 2-4.
This way we don't allow saturating all cores with tracing requests, risking starvation of essential jobs

/// Maximum number of concurrent tracing requests.
#[arg(long, value_name = "COUNT", default_value_t = constants::DEFAULT_MAX_TRACING_REQUESTS)]
pub rpc_max_tracing_requests: u32,

/// The default maximum number of concurrently executed tracing calls
pub const DEFAULT_MAX_TRACING_REQUESTS: u32 = 25;

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Mar 6, 2024
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started A-rpc Related to the RPC implementation and removed S-needs-triage This issue needs to be labelled labels Mar 6, 2024
@AbnerZheng
Copy link
Contributor

Can I give it a try?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants