fix(ui): safe call within useEffect teardown #11135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeHulpoi
requested review from
jmikrut,
jacobsfletch,
AlessioGr and
JarrodMFlesch
as code owners
paulpopus
approved these changes
Feb 12, 2025
jacobsfletch
pushed a commit
that referenced
this pull request
Feb 17, 2025
`NavProvider` useEffects teardown is trying to set `style` on an element that may not exist. The original code produces the following error:   Therefore, a condition has been added to check if `navRef.current` is truthy.
kendelljoseph
pushed a commit
that referenced
this pull request
Feb 21, 2025
`NavProvider` useEffects teardown is trying to set `style` on an element that may not exist. The original code produces the following error:   Therefore, a condition has been added to check if `navRef.current` is truthy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NavProvideruseEffects teardown is trying to setstyleon an element that may not exist. The original code produces the following error:Therefore, a condition has been added to check if
navRef.currentis truthy.