fix(ui): selection status not updating after toggleAll in useSelection hook #11218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrikKozak
requested review from
jmikrut,
jacobsfletch,
AlessioGr and
JarrodMFlesch
as code owners
…et to AllAvailable
paulpopus
approved these changes
Feb 18, 2025
jacobsfletch
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
After clicking "Select all"
toggleAll(true), manually deselecting an item does not update the overall selection status.The bulk actions remain visible, and
selectAllincorrectly stays asAllAvailable.How?
Updated
setSelection()logic to adjustselectAllwhen deselecting an item if it was previously set toAllAvailable.This ensures that the selection state updates correctly without altering the effect logic.
selectAllswitches to Some when an item is deselected after selecting all.Bulk actions now hide correctly if no items are selected.
Fixes #10836