Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Diff mentionned on HTML report but diff on JSON report #181

Open
LasneF opened this issue Feb 13, 2025 · 1 comment
Open

No Diff mentionned on HTML report but diff on JSON report #181

LasneF opened this issue Feb 13, 2025 · 1 comment

Comments

@LasneF
Copy link
Contributor

LasneF commented Feb 13, 2025

during a diff report i got this

Image

0 modification indicator on top , but something on the left (?)

doing the JSON report i got this , it pop up one breaking change that is so far not displayed

doing the Console report it crashes

                                                                                                                                                                                                                      panic: interface conversion: interface {} is model.ResponseChanges, not model.ExtensionChanges

goroutine 1 [running]:
github.com/pb33f/openapi-changes/tui.DigIntoObject[...](0xc002282580, 0xc002282600, {0xf60560, 0xc001d861d0?, 0xf60560?})
/home/runner/work/openapi-changes/openapi-changes/tui/build_tree.go:314 +0x173
github.com/pb33f/openapi-changes/tui.buildTreeNode(0xc002282580, {0xf605e0, 0xc001d861c0})
/home/runner/work/openapi-changes/openapi-changes/tui/build_tree.go:160 +0x2f99
github.com/pb33f/openapi-changes/tui.DigIntoObject[...](0xc002282380, 0xc002282580, {0xf605e0, 0xc002282428?, 0xf605e0?})
/home/runner/work/openapi-changes/openapi-changes/tui/build_tree.go:315 +0x113
github.com/pb33f/openapi-changes/tui.buildTreeNode(0xc002282380, {0xf607e0, 0xc002282400})
/home/runner/work/openapi-changes/openapi-changes/tui/build_tree.go:153 +0x30a5
github.com/pb33f/openapi-changes/tui.DigIntoObject[...](0xc002282280, 0xc002282380, {0xf607e0, 0xc00213ad10?, 0x0?})

openapi-changes report .\distant.yaml .\component-descriptor.yml
{
"reportSummary": {
"paths": {
"totalChanges": 6,
"breakingChanges": 1
}
},
"changes": [
{
"breaking": false,
"change": 1,
"changeHash": "gNTdYZopJFcr-n7VdfpRLuidwnL_alFZkzonhgc6KSs=",
"changeText": "modified",
"context": {
"newColumn": 20,
"newLine": 2038,
"originalColumn": 20,
"originalLine": 2086
},
"new": "Generic Error - see status code and description for more information.",
"original": "Internal Server Error",
"property": "description"
},
{
"breaking": true,
"change": 4,
"changeHash": "X7car0xhEMf-dhd-xUGMgaOWyYJ4pBcyVc_Cp7qgOPE=",
"changeText": "object_removed",
"context": {
"originalColumn": 18,
"originalLine": 2085
},
"new": "",
"original": "Internal Server Error",
"property": "x-summary"
},
{
"breaking": true,
"change": 4,
"changeHash": "1LwXu5aCYxNHB1dJG5pM4MWfhCkpKaPhvZ-VnVY3hQ4=",
"changeText": "object_removed",
"context": {
"originalColumn": 15,
"originalLine": 2093
},
"new": "",
"original": "unauthorized",
"property": "examples"
},
{
"breaking": false,
"change": 1,
"changeHash": "wuKlZ6NgnPM5PTvbwocTjLQnGfxVHuDQCEVZzDmdtP4=",
"changeText": "modified",
"context": {
"newColumn": 20,
"newLine": 2120,
"originalColumn": 20,
"originalLine": 2253
},
"new": "Internal Server Error",
"original": "Generic Error - see status code and description for more information.",
"property": "description"
},
{
"breaking": false,
"change": 3,
"changeHash": "EWb9PPVgvMmAB3o1nlz-FijzAuAFAk8goFAr5MxRzzU=",
"changeText": "object_added",
"context": {
"newColumn": 18,
"newLine": 2119
},
"new": "Internal Server Error",
"original": "",
"property": "x-summary"
},
{
"breaking": false,
"change": 3,
"changeHash": "uDSZPSqr5aUXqp0XCyQX-mwqg5W1eeh595N1GE2tbiU=",
"changeText": "object_added",
"context": {
"newColumn": 15,
"newLine": 2127
},
"new": "unauthorized",
"original": "",
"new": "unauthorized",
"original": "",
"property": "examples"
}
],
"commitDetails": {
"commitHash": "5df2ab",
"message": "New: .\component-descriptor.yml, Original: .\distant.yaml",
"author": "",
"authorEmail": "",
"committed": "2025-02-13T12:32:35.2538366+01:00",
"changeReport": null
}
}

@daveshanley
Copy link
Member

I need sample specs please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants