Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordion p-accordion toggle arrows seem reversed #17752

Open
1 of 4 tasks
esthersoftwaredev opened this issue Feb 23, 2025 · 0 comments
Open
1 of 4 tasks

Accordion p-accordion toggle arrows seem reversed #17752

esthersoftwaredev opened this issue Feb 23, 2025 · 0 comments
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@esthersoftwaredev
Copy link
Contributor

esthersoftwaredev commented Feb 23, 2025

Describe the bug

As I was using the accordion, placing it in a component in my v19 app, I took a look at the toggle arrows:

Image

when collapsed they are all pointing up and the element is chevronupicon

when I toggle the arrow of course does change to the opposite and becomes a chevrondownicon

Image

Pull Request Link

No response

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

I am not sure yet if this is intentional on not, and I prefer verifying before taking any further actions

Reproducer

https://stackblitz.com/run?file=components%2Flayout%2Fapp.component.html

Environment

Windows
Chrome
Angular v19.1.0
PrimeNG v19.0.6
Node v20.14.0

Angular version

19.1.0

PrimeNG version

v19

Node version

20.14.0

Browser(s)

Chrome

Steps to reproduce the behavior

  1. Go to https://primeng.org/accordion#accessibility
  2. Toggle panels of the accordion
  3. Observe the toggle arrows

Expected behavior

In my other apps where I am using accordions and just most accordions and similar actions have the arrows reversed and I am used to associating arrow-up with collapse & arrow down with - expand...

One of my apps with Angular Material UI:

Image

So in my latest app with PrimeNG, I am rotating them like this:

Image

It just feels more intuitive this way, to me at least.

Please let me know if it is ok to work on this and I can prepare a PR later on.

@esthersoftwaredev esthersoftwaredev added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

1 participant