Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong default icon on p-messages #17757

Closed
4 tasks
WynieCronje opened this issue Feb 24, 2025 · 0 comments · Fixed by #17756
Closed
4 tasks

Wrong default icon on p-messages #17757

WynieCronje opened this issue Feb 24, 2025 · 0 comments · Fixed by #17756
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
19.0.8

Comments

@WynieCronje
Copy link
Contributor

Describe the bug

Currently for any message severity on p-message it defaults to InfoCircleIcon.

Before the theming upgrade it worked fine.

Pull Request Link

#17756

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://stackblitz.com/edit/github-1g7w5pn4?file=src%2Fapp%2Fapp.component.html

Environment

Latest primng module

Angular version

19

PrimeNG version

v19

Node version

No response

Browser(s)

No response

Steps to reproduce the behavior

https://stackblitz.com/edit/github-1g7w5pn4?file=src%2Fapp%2Fapp.component.html

Expected behavior

Correct icons:

Image
@WynieCronje WynieCronje added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 24, 2025
@WynieCronje WynieCronje mentioned this issue Feb 24, 2025
Merged
@cetincakiroglu cetincakiroglu added this to the 19.0.8 milestone Feb 24, 2025
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Feb 24, 2025
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Feb 24, 2025
@cetincakiroglu cetincakiroglu linked a pull request Feb 24, 2025 that will close this issue
Fix wrong default icon in messages #17756
Merged
@github-project-automation github-project-automation bot moved this from Review to Done in PrimeNG Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
PrimeNG
Status: Done
Milestone
19.0.8
Development

Successfully merging a pull request may close this issue.

Fix wrong default icon in messages WynieCronje/primeng
2 participants
@WynieCronje @cetincakiroglu