This repository has been archived by the owner on Dec 21, 2024. It is now read-only.
ci: explicitly fmt check members #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainYou must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. You can enable merging using labels in your Graphite merge queue settings. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @AngelOnFira and the rest of your teammates on |
AngelOnFira
force-pushed
the
05-27-ci_explicitly_fmt_check_members
branch
from
178ea5d to
75b0bd0
Compare
AngelOnFira
changed the base branch from
05-27-fix_read_generated_manifest_fn_name
to
main
Merge activity
|
`sdks/` is getting caught in the fmt check, so this will just check `cli` and `core`. The alternative, adding an ignore to `rustfmt.toml`, will only work on nightly, and that would be harder to get set up correctly.
AngelOnFira
force-pushed
the
05-27-ci_explicitly_fmt_check_members
branch
from
75b0bd0 to
f14b17e
Compare
This was referenced May 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sdks/is getting caught in the fmt check, so this will just checkcliandcore. The alternative, adding an ignore torustfmt.toml, will only work on nightly, and that would be harder to get set up correctly.