Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECH-DEBT] Note Napalm-base is no longer supported, from Slack with Mircea Ulinic #61542

Closed
dmurphy18 opened this issue Jan 28, 2022 · 3 comments · Fixed by #62924
Closed

[TECH-DEBT] Note Napalm-base is no longer supported, from Slack with Mircea Ulinic #61542

dmurphy18 opened this issue Jan 28, 2022 · 3 comments · Fixed by #62924
Assignees
Labels
Confirmed Salt engineer has confirmed bug/feature - often including a MCVE Delta-Proxy dependency underlying Salt dependency issue Deprecation effort-large level of effort estimated in size P1 Priority 1 Sulfur v3006.0 release code name and version tech-debt

Comments

@dmurphy18
Copy link
Contributor

Note Napalm-base is no longer supported, from Slack with Mircea Ulinic
Network Engineer at DigitalOcean

Need to update this execution module to not rely on it

FYI @s0undt3ch as per request, and Slack conversation with Mircea
mirceaulinic:napalm: 11:33 AM
Hi. Sorry for late reply, haven't been much active over here lately... Napalm-base is no longer supported, napalm 2.5.0 is what you should be looking for. Let me know if you have any questions. 😉

Daithi 1:25 PM
thanks for the info, building packages to support napalm and napalm-base on Redhat, will drop napalm-base then, doing napalm 2.5.0, almost done. Thanks for getting back to me, created a native minion for Arista, only found out about your work after it was done (based on Salt 2019.2.2), re-invention of the wheel 😄 but that is how life goes.
mirceaulinic:napalm: 1:28 PM
Haha I know the feeling. Cool, looking forward to give it a whirl. Thanks for working on this!

david@david-lap2:~/devcode/dgm-salt-fix/salt/salt$ grep -r napalm-base *
runners/bgp.py: return (False, 'The napalm-base module could not be imported')
runners/net.py: from netaddr import IPNetwork # netaddr is already required by napalm-base
runners/net.py: return (False, 'The napalm-base module could not be imported')
utils/napalm.py: # from napalm-base
utils/napalm.py: # other than napalm-base.
utils/napalm.py: # For example, if napalm-base does not satisfy the requirements
utils/napalm.py: # we may need to define a custom library on top of napalm-base
utils/napalm.py: log.error('Falling back to napalm-base')

Originally posted by @dmurphy18 in #55222 (comment)

@dmurphy18 dmurphy18 added Confirmed Salt engineer has confirmed bug/feature - often including a MCVE Delta-Proxy dependency underlying Salt dependency issue Deprecation effort-large level of effort estimated in size P1 Priority 1 tech-debt and removed needs-triage labels Jan 28, 2022
@dmurphy18
Copy link
Contributor Author

This was noted back in Nov 18, 2019, in closed issue #55222

But working on current Napalm issue noticed we have still not done anything about removing the deprecated napalm.base (died in 2017) which is no longer used in napalm.

@dmurphy18 dmurphy18 changed the title Note Napalm-base is no longer supported, from Slack with Mircea Ulinic [TECH-DEBT] Note Napalm-base is no longer supported, from Slack with Mircea Ulinic Jan 28, 2022
@dmurphy18 dmurphy18 added this to the Sulphur v3006.0 milestone Feb 2, 2022
@dmurphy18 dmurphy18 added the Sulfur v3006.0 release code name and version label Feb 9, 2022
@garethgreenaway
Copy link
Contributor

I believe this one is already complete. We're not importing napalm-base anywhere in the code base.

@dmurphy18
Copy link
Contributor Author

Got a little cleanup left to do, we did make use of it back in Jan 28 when I checked.
A few droppings that should be cleaned up, from latest master branch

grep: doc/_build/doctrees/topics/installation/eos.doctree: binary file matches
doc/_build/html/topics/installation/eos.html:python-napalm-base-0.24.3-1.noarch.rpm
doc/_build/html/_sources/topics/installation/eos.rst.txt:    python-napalm-base-0.24.3-1.noarch.rpm
salt/utils/napalm.py:    # from napalm-base
salt/utils/napalm.py:        #   other than napalm-base.
salt/utils/napalm.py:        # For example, if napalm-base does not satisfy the requirements
salt/utils/napalm.py:        #   we may need to define a custom library on top of napalm-base
salt/utils/napalm.py:            log.error("Falling back to napalm-base")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Confirmed Salt engineer has confirmed bug/feature - often including a MCVE Delta-Proxy dependency underlying Salt dependency issue Deprecation effort-large level of effort estimated in size P1 Priority 1 Sulfur v3006.0 release code name and version tech-debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants