Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: UI changes for better consistancy and removal of certain unnecessary UI components #2500

Open
1 task done
VeraPhobia opened this issue Feb 22, 2025 · 6 comments

Comments

@VeraPhobia
Copy link

Checklist

  • I have searched for a similar issue in this repository and did not find one.

Description

i have made this issue after a comment i made in a pull request #2496

1.i believe that the icons used for the controller and the keyboard are more detailed that they should be and they use thin lines as well so they look our of place beside the other icons in the toolbar

{CA6DC29D-18E1-4DE0-8EC2-16E894B0EE71}
in my opinions simple icons with a little thicker lines will have a more consistent look with the rest
maybe something like these
https://www.flaticon.com/free-icon/game_13838536?term=game+controller&page=1&position=48&origin=tag&related_id=13838536

or something really simpler to keep it minimal like this one
https://www.flaticon.com/free-icon/console_686589?related_id=686589

and for keyboard maybe something simpler like this
https://www.flaticon.com/free-icon/keyboard_2507349?term=pc+keyboard&page=9&position=23&origin=search&related_id=2507349

  1. another thing that i think can be changed is the spacing or padding above and below the options, while this page looks nice because they are the same height, the other tabs like GUI, graphics and users don't follow the same logic, and each have their own padding amount. i feel making them all follow the same logic would be better, it can be eihter using the least amount of space or like the first tab using as much as necessary to make them the same height like the first tab
    {4512CCF3-A544-467A-B83D-DA0214A5118A}

3.another one is that (just in my opinion) the borders of the search is brighter than it should be? it looks fine in the light theme but in other themes the pure white can be tweaked a little maybe
{D048F9A2-9872-4076-B782-77CE891B5ED6}
by the way i do feel the theme options should be in the GUI section of the settings as well? or maybe just in the settings and not in the View menu only.

these ones are mostly things i don't understand why they exist if they are somehow needed then just ignore it

by right clicking the toolbar
{EE84F26E-9F21-4B10-95D6-1CD00EF16533}
you can use this game list toggle to disables the entire panel of game list, and you can do it with pressing that X in the corner of the game list as well
{C8582E37-F5FF-4640-B0A1-7BF41B4909C6}
and for some reason its different than the toggle that exist in the view options. maybe it can be removed?
and this is my opinion but i don't think anyone is going to have their game list as a separate windows so this option can be removed perhaps? i mean this option
Untitled

this one was another comments idea in the same PR but i feel he is correct i don't think this header should exist as well
Image

i want to say all of these are subjective maybe someone will have a better ideas than mine and im just being dumb. thank you for the great work tho, really appreciate it

Reason

Looks better

Examples

No response

@VeraPhobia VeraPhobia changed the title [Feature Request]: UI changes to better consistancy and removal of certain unnecessary components [Feature Request]: UI changes for better consistancy and removal of certain unnecessary UI components Feb 22, 2025
@GHU7924
Copy link

GHU7924 commented Feb 22, 2025

I am partially duplicating my comment.

Interface

I think that the items highlighted in yellow can actually be deleted, because:

  1. I also don't see the point in separating the list from the emulator.
  2. Showing these two elements by right-clicking, especially since these options can feel great in the "View" section.

@jardon
Copy link
Contributor

jardon commented Feb 22, 2025

this is what those first set of icons would look like without further editing:

Image

the current ones for comparison:

Image

theyre better, but only marginally. i agree they need to be more consistent. idk if that means making the other icons smaller/thinner or making the controller/kb icons bigger/thicker

@VeraPhobia
Copy link
Author

@jardon i think the main issue is that the controller and the keyboard icons cant be fully centered because of their shape the controller will be bottom heavy and the keyboard will be side heavy as a rectangle or be bottom heavy like what you showed as an example.

maybe the correct way will be filling the icons like how rpcs3 does?

Image

but then again i feel their icons have the same issue of not being the same size and the spacing seems off as well

@jardon
Copy link
Contributor

jardon commented Feb 22, 2025

i think the shape is part of it. we can set the icon shape to be a rectangle making the controller fill more vertical space which i think would be helpful. iconography is hard and its easy to have things mismatched when theyre just being downloaded from random places on the internet.

the UI really needs some work. i wonder if we could combine controller/kb to a single icon, but that would require reworking the entirety of the input GUIs

@VeraPhobia
Copy link
Author

in order to save as much as what is already there, how about combining the controller and keyboard input into a same page, i feel how ryujing used to do it was perfect (rip btw)

Image

the user simply chooses between the input devices available, and each device kind of got its own configuration so they dont mess with each other. currently chadps4 have a preset of actions the user can bind each key and frankly i felt it was a very limiting way anyway. in the feature the hero who takes the torch to refactor it should make it possible to bind anything and with that i feel combining the keyboard can be possible as well.

@slick-daddy
Copy link
Contributor

I really liked the ideas here. They are not implemented yet but even looking at them makes me feel that I am using more intuitive GUI. I wonder what others think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants