fix: audio label when selecting variants by label #8038
Merged
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
remi-monnot
force-pushed
the
fix-audio-select-variant-by-label
branch
from
8d10bdd to
f08b98d
Compare
remi-monnot
changed the title
remi-monnot
force-pushed
the
fix-audio-select-variant-by-label
branch
from
f08b98d to
7f2d0e5
Compare
tykus160
requested changes
Feb 7, 2025
avelad
added
type: bug
|
Incremental code coverage: 0.00% |
tykus160
approved these changes
Feb 7, 2025
|
Thanks! |
avelad
pushed a commit
that referenced
this pull request
Feb 17, 2025
This was introduced with version 4.13.0 This is a simple oversight on arguments of the function `this.currentAdaptationSetCriteria_.configure(...)` and made sure this was following the doc here https://shaka-player-demo.appspot.com/docs/api/shaka.media.AdaptationSetCriteria.html#.Configuration Fixes #8037
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced with version 4.13.0
This is a simple oversight on arguments of the function
this.currentAdaptationSetCriteria_.configure(...)and made sure this was following the doc here https://shaka-player-demo.appspot.com/docs/api/shaka.media.AdaptationSetCriteria.html#.ConfigurationFixes #8037