Skip to content
This repository has been archived by the owner on Jan 24, 2025. It is now read-only.

Objects with multi-line toString method are not rendered properly in diff results #433

Closed
UnaiUribarri-TomTom opened this issue Mar 22, 2023 · 3 comments

Comments

@UnaiUribarri-TomTom
Copy link
Contributor

UnaiUribarri-TomTom commented Mar 22, 2023

I have problem rendering results in a class like this:

// Some classes defined in https://github.com/openstreetmap/OSM-binary/blob/master/osmpbf/osmformat.proto
import org.osm.protobuf.Node
import org.osm.protobuf.Way
import org.osm.protobuf.Relation 

case class GeoMap(nodes: Seq[Node], ways: Seq[Way], relations: Seq[Relation])

Inner objects (Node, Way, Relation) are not properly indented and also, only the first line is highlighted when there is a difference.

I have posted PR #432 that resolves both issues.

@UnaiUribarri-TomTom
Copy link
Contributor Author

I realised that the example provided did not trigger the issue. The issue was caused by a list of protobuf objects; protobuf defines a toString method that produces a multiline result. Updated the title of this issue.

@UnaiUribarri-TomTom UnaiUribarri-TomTom changed the title Complex Objects are not rendered properly in diff results Objects with multi-line toString method are not rendered properly in diff results Mar 23, 2023
@ghostbuster91
Copy link
Collaborator

New version has been released with #432, should we close the issue?

@ghostbuster91
Copy link
Collaborator

Thanks I've just noticed that the release build failed. I will try to fix it and retry later today.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants