Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TeXtidote allows LanguageTool to proofread inside backtick quotes #152

Closed
oblitum opened this issue Oct 3, 2020 · 5 comments
Closed

TeXtidote allows LanguageTool to proofread inside backtick quotes #152

oblitum opened this issue Oct 3, 2020 · 5 comments
Labels
enhancement New feature or request
Milestone

Comments

@oblitum
Copy link

oblitum commented Oct 3, 2020

TeXtidote causes LanguageTool to proofread inside triple backtick blocks in Markdown files. This is not the LanguageTool default behavior, which will ignore content in such blocks, which are used for code. LanguageTool does warn about the backticks themselves ("Use a smart opening quote here"), no idea why.\

TeXtidote allows LanguageTool to proofread inside backtick quotes in Markdown files. This is the LanguageTool default behavior, which doesn't ignore contents in such quotes and even suggests replacing such quotation for other kind. TeXtidote should handle that I think?

@sylvainhalle
Copy link
Owner

I tested with this input file:

Hello, my name is Bill.

```
foobar
```

What about you?

I got no error for the part between backticks. Could you please post a minimum working example that reproduces the issue?

@oblitum
Copy link
Author

oblitum commented Oct 5, 2020

Never mind, this was a mistake on my part. The actual issue is with single backticks, it will point spelling errors for content like

`sysctl`

But it happens in both tools (languagetool -l en-US, textidote --check en_US). Shouldn't TeXtidote stop proofreading there?

@oblitum oblitum changed the title TeXtidote causes LanguageTool to proofread inside triple backtick blocks TeXtidote causes LanguageTool to proofread inside backtick quotes Oct 6, 2020
@sylvainhalle
Copy link
Owner

I think that if LT analyzes what is between backticks, TeXtidote should do the same in order to be consistent.

@oblitum
Copy link
Author

oblitum commented Oct 6, 2020

Okay, I just think it doesn't make sense to proofread inside code quotes, it should be excluded just like inside LaTeX formulas?

@sylvainhalle
Copy link
Owner

It's true that in the LaTeX cleaner, the equivalent command (\verb+) is replaced by a dummy placeholder. The same could be done for Markdown with single ticks.

@sylvainhalle sylvainhalle reopened this Oct 6, 2020
@sylvainhalle sylvainhalle added the enhancement New feature or request label Oct 6, 2020
@sylvainhalle sylvainhalle added this to the v0.8.2 milestone Oct 6, 2020
@oblitum oblitum changed the title TeXtidote causes LanguageTool to proofread inside backtick quotes TeXtidote allows LanguageTool to proofread inside backtick quotes Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants