fix(drain): delay queuekey for redis cluster #3074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manast
reviewed
Feb 12, 2025
|
Ok; I get the intent now. I think the the solution would be to pass a new ARGV with a boolean to express if the delayed jobs should also be deleted or not, and always pass the delayed key, that should work. It was an odd pattern to have a key that can sometimes be undefined anyway. |
|
i update the drain script using a new ARGV. |
roggervalf
force-pushed
the
fix-cluster-drain
branch
from
9f932a1 to
2dceb2c
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Feb 14, 2025
## [5.40.5](v5.40.4...v5.40.5) (2025-02-14) ### Bug Fixes * **drain:** pass delayed key for redis cluster ([#3074](#3074)) ([05ea32b](05ea32b))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
fix crossslot error when running queue.drain() in redis cluster
How
replace '' key with queue.toKey('') to include hash tag