Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load ClientConfig from cache #10237

Open
FelixMalfait opened this issue Feb 16, 2025 · 2 comments
Open

Load ClientConfig from cache #10237

FelixMalfait opened this issue Feb 16, 2025 · 2 comments
Assignees
@eliasylonen
Labels
blocked: tech spec needed type: chore

Comments

@FelixMalfait
Copy link
Member

ClientConfig request is render-blocking (see ClientConfigProviderEffect and ClientConfigProvider)

I think we should try a cache-first policy in Apollo to speed up first-page loading.

Make sure it doesn't cause re-render if the clientConfig is the same
@FelixMalfait
Copy link
Member Author

Second thought: should we pass the app's version in ClientConfig, frontend also has the version from package.json and we only refetch clientConfig if the version is different?

@FelixMalfait
Copy link
Member Author

cc @charlesBochet for input

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eliasylonen eliasylonen

Labels
blocked: tech spec needed type: chore
Projects
🎯 Roadmap & Sprints
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eliasylonen @FelixMalfait