Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature revert_on_error doesn't work #985

Closed
xgreenx opened this issue Oct 26, 2021 · 0 comments · Fixed by #998
Closed

Feature revert_on_error doesn't work #985

xgreenx opened this issue Oct 26, 2021 · 0 comments · Fixed by #998

Comments

@xgreenx
Copy link
Collaborator

xgreenx commented Oct 26, 2021 •
edited
Loading

is_result_type returns false for Output. So during execution, the contract will be not reverted. #984 adds two tests to reproduce the problem and also provides a possible solution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ink! message result return reverts use-ink/ink
1 participant
@xgreenx