Ignoring parsing errors of parseHeaders in client.go #1917
Comments
|
A pull request would be welcome. Preferably matching net/http in behavior. |
|
In That is to say, when processing headers, there is no error if the header key contains "spaces" in See the example below: header with the key include space func main() {
rawRequest := "HTTP/1.1 200 OK\r\nRefer Policy: origin\r\n\r\n"
fmt.Println("net/http:")
reader := strings.NewReader(rawRequest)
res, err := http.ReadResponse(bufio.NewReader(reader), nil)
if err != nil {
log.Println(err)
} else {
fmt.Printf("%#v\n", res.Header)
}
fmt.Println("fasthttp:")
req2 := fasthttp.AcquireResponse()
defer fasthttp.ReleaseResponse(req2)
reader.Seek(0, io.SeekStart)
err = req2.Read(bufio.NewReader(reader))
if err != nil {
log.Println(err)
} else {
req2.Header.VisitAll(func(key []byte, value []byte) {
fmt.Println(string(key), string(value))
})
}
}header with empty key func main() {
rawRequest := "HTTP/1.1 200 OK\r\n: empty key\r\n\r\n"
fmt.Println("net/http:")
reader := strings.NewReader(rawRequest)
res, err := http.ReadResponse(bufio.NewReader(reader), nil)
if err != nil {
log.Println(err)
} else {
fmt.Printf("%#v\n", res.Header)
}
fmt.Println("fasthttp:")
req2 := fasthttp.AcquireResponse()
defer fasthttp.ReleaseResponse(req2)
reader.Seek(0, io.SeekStart)
err = req2.Read(bufio.NewReader(reader))
if err != nil {
log.Println(err)
} else {
req2.Header.VisitAll(func(key []byte, value []byte) {
fmt.Println(string(key), string(value))
})
}
}net/http:
2024/12/13 08:58:36 malformed MIME header line: : empty key
fasthttp:
2024/12/13 08:58:36 error when reading response headers: invalid header key "". Buffer size=32, contents: "HTTP/1.1 200 OK\r\n: empty key\r\n\r\n" |
|
Yes, I can confirm the issue too. Temporarily, I wrote an error handler and allowed it to pass any "invalid header" error(s). Then, I used |
|
Hi, I am currently fixing this issue. Here are a few points to note:
|
|
It's ok to modify test to match the behaviour of net/http. |
Make behavior consistent with net/http by allowing header keys and trailers containing spaces without canonicalizing them
* fix: accept invalid headers with a space #1917 Make behavior consistent with net/http by allowing header keys and trailers containing spaces without canonicalizing them * fix: lint paramTypeCombine * fix: #1953 (comment) * fix: golangci-lint nestingReduce
I have to deal with the wrong response header (
Referrer Policy, notReferrer-Policymaybe a typo?) sent by the server, but fasthttp causes an error, the moment I receive the wrong header field, and everything goes down. To deal with this, there is nothing I can do but change the fasthttp code. Simply deleting the validHeaderFieldByte in parseHeaders works fine. Browsers also generally seem to just ignore those fields.Could you please provide a way to ignore the wrong header field? I think it would be enough to optionally disable header field validation, or provide a way to modify validHeaderFieldByteTable.
The text was updated successfully, but these errors were encountered: