From 6254a6c76ad54a33c156647e8e492cf1e9f907f1 Mon Sep 17 00:00:00 2001
From: Pedro Valido <80268365+pedrovalido@users.noreply.github.com>
Date: Thu, 24 Oct 2024 12:50:55 +0100
Subject: [PATCH] fix: missing external functions on helper, remove unused from
 ISugarHelper interface

---
 contracts/LpSugar.vy       |  4 ----
 contracts/LpSugarModule.vy | 14 +++++++++++++-
 2 files changed, 13 insertions(+), 5 deletions(-)

diff --git a/contracts/LpSugar.vy b/contracts/LpSugar.vy
index 8e028bc..0d4280a 100644
--- a/contracts/LpSugar.vy
+++ b/contracts/LpSugar.vy
@@ -271,14 +271,10 @@ interface ISugarHelper:
   def epochLatestByAddress(_address: address, _gauge: address) -> LpEpoch: view
   def epochsByAddress(_limit: uint256, _offset: uint256, _address: address) \
       -> DynArray[LpEpoch, MAX_EPOCHS]: view
-  def epochRewards(_ts: uint256, _reward: address) \
-      -> DynArray[LpEpochReward, MAX_REWARDS]: view
   def poolRewards(_venft_id: uint256, _pool: address, _gauge: address) \
       -> DynArray[Reward, MAX_POOLS]: view
   def fetchNfpm(_factory: address) -> address: view
   def safeBalanceOf(_token: address, _address: address) -> uint256: view
-  def safeDecimals(_token: address) -> uint8: view
-  def safeSymbol(_token: address) -> String[100]: view
   def isRootFactory(_factory: address) -> bool: view
 
 
diff --git a/contracts/LpSugarModule.vy b/contracts/LpSugarModule.vy
index 16bf96d..8fae19b 100644
--- a/contracts/LpSugarModule.vy
+++ b/contracts/LpSugarModule.vy
@@ -748,6 +748,12 @@ def _cl_position(
 
   return pos
 
+@external
+@view
+def v2Position(_account: address, _pool: address) -> Position:
+  return self._v2_position(_account, _pool)
+
+@internal
 @view
 def _v2_position(_account: address, _pool: address) -> Position:
   """
@@ -1188,10 +1194,16 @@ def _safe_symbol(_token: address) -> String[100]:
   )
 
   if success:
-    return abi_decode(response, String[100])
+    return _abi_decode(response, String[100])
 
   return "-NA-"
 
+@external
+@view
+def isRootFactory(_factory: address) -> bool:
+  return self._is_root_factory(_factory)
+
+@internal
 @view
 def _is_root_factory(_factory: address) -> bool:
   """