Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] v0.32.0+ json camelCase coverage #3288

Closed
mdechiaro opened this issue Nov 16, 2023 · 1 comment
Closed

[BUG] v0.32.0+ json camelCase coverage #3288

mdechiaro opened this issue Nov 16, 2023 · 1 comment

Comments

@mdechiaro
Copy link
Contributor

Describe the bug
As per v32 changelog, json types were converted to camelCase. It appears some were missed, e.g. the Type and Name keys when using govc device.info command.

To Reproduce
Steps to reproduce the behavior:

govc device.info -u <vcenter> -dc <datacenter> -vm <vm_name> -json
{
  "devices": [
    {
      "Name": "ide-200",
      "Type": "VirtualIDEController",
      "key": 200,
      "deviceInfo": {
        "label": "IDE 0",
        "summary": "IDE 0"
      },
      "busNumber": 0
    },
    {
      "Name": "disk-1000-0",
      "Type": "VirtualDisk",
      "key": 2000,
      "deviceInfo": {
        "label": "Hard disk 1",
        "summary": "52,428,800 KB"
      },
...shorten for brevity

Expected behavior
I would expect these key names to be consistent with camelCase change that occurred.

Affected version

govc 0.33.0

Screenshots/Debug Output
If applicable, add screenshots or debug output to help explain your problem.

Additional context

@mdechiaro
Copy link
Contributor Author

I came across this comment in #3241 that explains it, so I think this is expected behavior. I'll close this as a duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant