Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump to latest probot again #658

Merged
merged 6 commits into from
Feb 10, 2024
Merged

fix: bump to latest probot again #658

merged 6 commits into from
Feb 10, 2024

Conversation

gr2m
Copy link
Collaborator

@gr2m gr2m commented Feb 10, 2024

Copy link

vercel bot commented Feb 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2024 8:51pm

api/index.js Outdated
Comment on lines 25 to 29
module.exports.config = {
api: {
bodyParser: false,
},
};
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that didn't work, I still get the singnature problems

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pointer! I'll investigate this another time: #659

api/index.js Outdated
Comment on lines 10 to 14
export const config = {
api: {
bodyParser: false,
},
};
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using ES Module didn't work either

@gr2m
Copy link
Collaborator Author

gr2m commented Feb 10, 2024

Setting NODEJS_HELPERS to false worked, but I'd rather disable the body parsing explicitly in code instead of relying on this environment variable, as many folks rely on wip/app as a reference GitHub App.

@gr2m gr2m merged commit cdba9f7 into master Feb 10, 2024
4 checks passed
@gr2m gr2m deleted the upgrade-to-probot-v13-again branch February 10, 2024 20:55
Copy link

🎉 This PR is included in version 5.0.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants