-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bump to latest probot again #658
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
api/index.js
Outdated
module.exports.config = { | ||
api: { | ||
bodyParser: false, | ||
}, | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that didn't work, I still get the singnature problems
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://vercel.com/guides/how-do-i-get-the-raw-body-of-a-serverless-function
It seems that you need another function
We have similar code in Octokit,https://github.com/octokit/webhooks.js/blob/d51daf8d3f2b50cd250e367fec85d62825268f13/src/middleware/node/get-payload.ts#L30-L45
I'm not sure why it isn't working though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pointer! I'll investigate this another time: #659
api/index.js
Outdated
export const config = { | ||
api: { | ||
bodyParser: false, | ||
}, | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using ES Module didn't work either
Setting |
🎉 This PR is included in version 5.0.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
see probot/probot#1973 (comment) thanks @wolfy1339