Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(kitsu): update dependency axios to ~0.21.0 #463

Merged
merged 2 commits into from
Oct 25, 2020
Merged

build(kitsu): update dependency axios to ~0.21.0 #463

merged 2 commits into from
Oct 25, 2020

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 22, 2020 •
edited
Loading

This PR contains the following updates:

Package Type Update Change
axios dependencies minor ~0.19.2 -> ~0.21.0
axios devDependencies minor ~0.19.2 -> ~0.21.0

Release Notes

axios/axios

v0.21.0

Compare Source

Fixes and Functionality:

  • Fixing requestHeaders.Authorization (#​3287)
  • Fixing node types (#​3237)
  • Fixing axios.delete ignores config.data (#​3282)
  • Revert "Fixing overwrite Blob/File type as Content-Type in browser. (#​1773)" (#​3289)
  • Fixing an issue that type 'null' and 'undefined' is not assignable to validateStatus when typescript strict option is enabled (#​3200)

Internal and Tests:

  • Lock travis to not use node v15 (#​3361)

Documentation:

Huge thanks to everyone who contributed to this release via code (authors listed below) or via reviews and triaging on GitHub:

v0.20.0

Compare Source

Release of 0.20.0-pre as a full release with no other changes.

Renovate configuration

📅 Schedule: "before 9am,after 5pm" in timezone Europe/London.

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@wopian
Copy link
Owner

wopian commented Aug 22, 2020 •
edited
Loading

Blocked by breaking bug. See axios/axios#3220

@renovate renovate bot force-pushed the renovate/axios-0.x branch 2 times, most recently from 437d474 to e0c2708 Compare August 22, 2020 17:01
@renovate renovate bot changed the title build(kitsu): update dependency axios to v0.20.0 build(kitsu): update dependency axios to ~0.20.0 Aug 22, 2020
@wopian
Copy link
Owner

wopian commented Aug 22, 2020

Released 10.0.0-alpha.6 and 9.1.15 minor pinned to [email protected].

This will need reverting back to a major pin once the bug in [email protected] has been fixed.

@renovate renovate bot force-pushed the renovate/axios-0.x branch 3 times, most recently from a1c2ef3 to e0910eb Compare September 2, 2020 21:59
@renovate renovate bot force-pushed the renovate/axios-0.x branch 3 times, most recently from c5a3bda to ef042f2 Compare September 11, 2020 15:12
@wopian wopian mentioned this pull request Sep 12, 2020
Closed
@wopian
Copy link
Owner

wopian commented Sep 12, 2020

Bug fixed in axios/axios#3282, waiting on merge and release.

@renovate renovate bot force-pushed the renovate/axios-0.x branch 3 times, most recently from 613c6a9 to 5bcd356 Compare September 18, 2020 11:02
@renovate renovate bot force-pushed the renovate/axios-0.x branch from 5bcd356 to 6ef9fe1 Compare September 22, 2020 18:21
@renovate renovate bot force-pushed the renovate/axios-0.x branch from 6ef9fe1 to 081fba0 Compare October 1, 2020 22:21
@wopian
Copy link
Owner

wopian commented Oct 1, 2020

PR fixing the bug has been merged, awaiting an Axios patch release.

@renovate renovate bot force-pushed the renovate/axios-0.x branch 2 times, most recently from f7a5b85 to 6a87895 Compare October 7, 2020 20:06
@renovate renovate bot force-pushed the renovate/axios-0.x branch 3 times, most recently from b226c32 to f6d9b50 Compare October 14, 2020 23:57
@renovate renovate bot force-pushed the renovate/axios-0.x branch 3 times, most recently from 25a3ad7 to 6548edb Compare October 20, 2020 20:33
@jasonsaayman
Copy link

Hi,

Axios version 0.21.0 has been released 🎉 please use that and let us know if that solves your issue.

Thanks

@renovate renovate bot force-pushed the renovate/axios-0.x branch from 6548edb to eaa6f4f Compare October 24, 2020 17:50
@renovate renovate bot changed the title build(kitsu): update dependency axios to ~0.20.0 build(kitsu): update dependency axios to ~0.21.0 Oct 24, 2020
wopian
wopian requested changes Oct 24, 2020
View reviewed changes
Copy link
Owner

@wopian wopian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporary fix to minor pin can be reverted to major pin on 0.21

@renovate renovate bot force-pushed the renovate/axios-0.x branch from eaa6f4f to fc4d5f2 Compare October 25, 2020 15:57
@wopian
revert: restore axios to a major pin
03548b8 
Breaking change in 0.20 has been fixed in 0.21
@codeclimate
Copy link

codeclimate bot commented Oct 25, 2020

Code Climate has analyzed commit 03548b8 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@wopian wopian merged commit 3f9f996 into master Oct 25, 2020
@wopian wopian deleted the renovate/axios-0.x branch October 25, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wopian wopian wopian approved these changes

Assignees

@wopian wopian

Labels
dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wopian @jasonsaayman @renovate-bot