Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

partialRatio issue #39

Closed
overwerk opened this issue Nov 18, 2017 · 3 comments · Fixed by #80
Closed

partialRatio issue #39

overwerk opened this issue Nov 18, 2017 · 3 comments · Fixed by #80
Labels
bug on-hold The issue is on hold

Comments

@overwerk
Copy link

FuzzySearch.partialRatio("kaution", "kdeffxxxiban:de1110010060046666666datum:16.11.17zeit:01:12uft0000899999tan076601testd.-20-maisonette-z4-jobas-hagkautionauszug");

Result is "57", I expect "100".

Using 1.1.9.
@xdrop xdrop added the bug label Nov 19, 2017
@xdrop xdrop added this to the 1.1.10 milestone Nov 19, 2017
@xdrop
Copy link
Owner

xdrop commented Nov 20, 2017

Related:
seatgeek/fuzzywuzzy#79
ztane/python-Levenshtein#16

@xdrop xdrop added the on-hold The issue is on hold label Mar 21, 2018
@xdrop xdrop modified the milestones: 1.1.10, 1.2.0 Mar 23, 2018
@xdrop xdrop removed this from the 1.2.0 milestone Nov 16, 2018
@BobLd BobLd mentioned this issue Apr 14, 2020
Merged
@BobLd
Copy link

BobLd commented Apr 14, 2020 •
edited
Loading

Problem apparently comes from DiffUtils.editOpsFromCostMatrix(): The if statement from line 159

fuzzywuzzy/diffutils/src/me/xdrop/diffutils/DiffUtils.java

Lines 159 to 169 in 4783229

if (i != 0 && j != 0 && matrix[ptr] == matrix[ptr - len2 - 1]
&& c1[p1 + i - 1] == c2[p2 + j - 1]) {
i--;
j--;
ptr -= len2 + 1;
dir = 0;
continue;
}
should be moved to be the first if statement (moved to line 130)

fuzzywuzzy/diffutils/src/me/xdrop/diffutils/DiffUtils.java

Line 130 in 4783229

if (dir < 0 && j != 0 && matrix[ptr] == matrix[ptr - 1] + 1) {

@burdoto burdoto mentioned this issue Apr 15, 2020
Merged
@xdrop xdrop closed this as completed in #80 Apr 15, 2020
@xdrop
Copy link
Owner

xdrop commented Apr 18, 2020

1.3.0 now in staging. Will be available soon.

@maxbachmann maxbachmann mentioned this issue Nov 15, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug on-hold The issue is on hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix PartialRatio issue comroid-git/fuzzywuzzy
3 participants
@xdrop @overwerk @BobLd