-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a minimal example using a generic fragment adapter #1105
Comments
I'm using an adapter that (if I understand the issue right) is roughly such an adapter, most easly viewed as its introducing patch. [edit] I should add that this is loosely based on cheako's adapter for a reference component in the path. Using an adapter is a bit awkward as it means that at least where it is used with a Router, the actual route enum needs to be packed into and out of the adapter. Might it not be preferable to have an option in the Switch derivation process to take the decision to disregard the pre-fragment of the URI right away? That might even be possible automatically if all the "to" start with a hash. |
@hamza1311 What's the situation for this with the new router? |
Honestly, I have no idea what issue is about. I don't understand what a "generic fragment adapter" is. |
I guess this issue is no longer relevant anyway since it's about an example, but AFAIK the new router doesn't handle fragments (the part starting with |
Sure. I'm not sure how the implementation would look like. If you open the issue, I'd appreciate if you added some notes about implementation details |
Closing in favour of #1858 |
Description
yewstack/yew_router#211 Made it possible to have proper fragment routing by wrapping a normal parser with an adapter that also implements Switch and matches anything up to a
#
.An example should be created to demonstrate ho to create the adapter.
It should use the full featureset of the library, but be contained to just a single main.rs file in the same way that the minimal example is.
The text was updated successfully, but these errors were encountered: