Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fail when passing CONFIG_ string assignment from the command line #86167

Open
fabiobaltieri opened this issue Feb 21, 2025 · 3 comments
Open
Assignees
Labels
area: Build System bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug Regression Something, which was working, does not anymore

Comments

@fabiobaltieri
Copy link
Member

fabiobaltieri commented Feb 21, 2025

Describe the bug
Hey folks, looks like passing string configs from the command line broke with #85994

$ west build -p -b nrf52dk/nrf52832 samples/hello_world/ -DCONFIG_BOOT_BANNER_STRING=\"broken\"
...
CMake Error at /home/fabiobaltieri/zephyrproject/zephyr/cmake/modules/yaml.cmake:552 (string):
  string sub-command JSON failed parsing json string: * Line 81, Column 134

    Missing ',' or '}' in object declaration

  .

added a print for ${json} to figure what's going on and this is the problematic line:

    "command" : "/home/fabiobaltieri/.venv/bin/west build -p -b nrf52dk/nrf52832 samples/hello_world/ -DCONFIG_BOOT_BANNER_STRING=\\"broken\\"",

usual multiple escape issue it seems.

@tejlmand @pillo79 @nordicjm could any of you folks look into it?

Thanks!

To Reproduce
See above

Expected behavior
Build happily

Impact
It's pretty bad

Environment (please complete the following information):
v4.1.0-rc2, Zephyr SDK, Linux, the usual

@fabiobaltieri fabiobaltieri added bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug Regression Something, which was working, does not anymore area: Build System labels Feb 21, 2025
@fabiobaltieri
Copy link
Member Author

cc @kartben

@kartben
Copy link
Collaborator

kartben commented Feb 22, 2025

#86151 reports a similar issue

@noahp
Copy link
Contributor

noahp commented Feb 23, 2025

Also impacting our CI, we've reverted for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Build System bug The issue is a bug, or the PR is fixing a bug priority: high High impact/importance bug Regression Something, which was working, does not anymore
Projects
None yet
Development

No branches or pull requests

4 participants