Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an optional std feature that implements std::error::Error #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

phil-opp
Copy link

The std::error::Error trait is required for some error handling frameworks. This pull request adds an optional std feature that implements it for the Error enum.

The new std feature is also useful if linreg is compiled together with other dependencies that also use the displaydoc crate, but with its default feature set. Since Cargo unifies all dependency features, displaydoc is compiled with its std feature enabled, even though linreg sets default-features = false for it. This results in a compilation failure if the std library is not included in linreg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant