[7.4-stable] Resizable elements window #3187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to drag the divider between the preview and elements windows in order to resize the elements window. This is very helpful, if the elements window is too narrow when lots of nested elements exist. (cherry picked from commit 5e510e5) # Conflicts: # app/assets/builds/alchemy/admin.css # app/assets/builds/alchemy/admin.css.map # app/assets/builds/alchemy/custom-properties.css.map # app/assets/builds/alchemy/welcome.css.map # app/assets/builds/tinymce/skins/content/alchemy/content.min.css.map # app/assets/stylesheets/alchemy/admin/elements.scss # app/assets/stylesheets/alchemy/admin/navigation.scss # app/stylesheets/alchemy/admin/preview_window.scss
Makes sure the elements window width is the same across pages. Uses a cookie, so we can read the value from Rails and put it on the body tag, so it is immediatly available on page render. Otherwise we would see the element window resizing on every page visit. SSR ftw \o/ (cherry picked from commit 44d3a39)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 7.4-stable #3187 +/- ##
===========================================
Coverage 96.46% 96.46%
===========================================
Files 238 238
Lines 6454 6454
===========================================
Hits 6226 6226
Misses 228 228 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto7.4-stable:Questions ?
Please refer to the Backport tool documentation