fix: Send C-c to stop background process when stop button is clicked #6846
+215
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the stop button is clicked, it only changes the agent state but doesn't actually stop the running process. This causes the process to continue running in the background, preventing new commands from being executed. This fix modifies the AgentController to send a C-c command to stop any running process when transitioning to the STOPPED state. This ensures that background processes are properly terminated when the stop button is clicked. Added tests: - test_bash_session_stop_behavior: Shows the issue with background processes - test_bash_session_stop_command: Shows that C-c properly stops processes - test_agent_controller_stop: Verifies the fix works correctly
neubig
changed the title
When the stop button is clicked, it sends a C-c command to stop any running process. This command needs to be marked as a user action to avoid requiring tool call metadata when the agent processes it. - Added _source parameter to CmdRunAction to set source at creation time - Set source='user' when creating C-c command - Added tests to verify agent can process C-c command without error
- Use _ to indicate intentionally unused variables - Add comments explaining why we don't use the message results
malhotra5
reviewed
Feb 20, 2025
enyst
reviewed
Feb 20, 2025
| # Send C-c as a user action to avoid tool call metadata requirement | ||
| stop_action = CmdRunAction(command='C-c', is_input=True) | ||
| # Add as a user event to avoid tool call metadata requirement | ||
| self.event_stream.add_event(stop_action, EventSource.USER) |
There was a problem hiding this comment.
If we need to do this, what do you think about doing it in the method just above, _reset at line 430? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the stop button is clicked, it only changes the agent state but does not actually stop the running process. This causes the process to continue running in the background, preventing new commands from being executed.
This fix modifies the AgentController to send a C-c command to stop any running process when transitioning to the STOPPED state. This ensures that background processes are properly terminated when the stop button is clicked.
Changes:
_sourcefield from CmdRunAction as it is not the right approachEventSource.USERproperly when adding events to the event streamAdded tests:
Fixes #6848
To run this PR locally, use the following command: