The Witness: Fix non-deterministic hints #2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NewSoupVi
added
the
is: bug/fix
Exempt-Medic
approved these changes
Nov 27, 2023
Berserker66
approved these changes
Dec 10, 2023
Magnemania
pushed a commit
to Magnemania/Archipelago
that referenced
this pull request
Jan 3, 2024
Jouramie
pushed a commit
to Jouramie/Archipelago
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exempt-Medic discovered that the in-game hints have been non-deterministic for a while. This should address that, mostly by changing some sets to lists and doing a sorted() call on the remaining set.
Exempt-Medic has verified that the hints seem to be deterministic now.