Lingo: Fixed edge case sunwarp shuffle accessibility issue #3228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
hatkirby
added
the
is: bug/fix
Exempt-Medic
approved these changes
May 6, 2024
hatkirby
added
waiting-on: core-review
NewSoupVi
approved these changes
May 19, 2024
jnschurig
pushed a commit
to Tranquilite0/Archipelago-SoulBlazer
that referenced
this pull request
Jun 13, 2024
…goMW#3228) * Lingo: Fixed edge case sunwarp shuffle accessibility issue * Minor readability update --------- Co-authored-by: NewSoupVi <[email protected]>
sflavelle
pushed a commit
to sflavelle/Archipelago-tgc
that referenced
this pull request
Jun 20, 2024
…goMW#3228) * Lingo: Fixed edge case sunwarp shuffle accessibility issue * Minor readability update --------- Co-authored-by: NewSoupVi <[email protected]>
qwint
pushed a commit
to qwint/Archipelago
that referenced
this pull request
Jun 24, 2024
…goMW#3228) * Lingo: Fixed edge case sunwarp shuffle accessibility issue * Minor readability update --------- Co-authored-by: NewSoupVi <[email protected]>
AustinSumigray
pushed a commit
to AustinSumigray/Archipelago
that referenced
this pull request
Jan 4, 2025
…goMW#3228) * Lingo: Fixed edge case sunwarp shuffle accessibility issue * Minor readability update --------- Co-authored-by: NewSoupVi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
An intermittent generation failure was found involving painting shuffle, sunwarp shuffle, vanilla doors, and the region "Owl Hallway". Accessing the Owl Hallway is required in order to get roof access in vanilla doors. The Owl Hallway can only be accessed through painting in vanilla doors, meaning that, with painting shuffle on, the painting that leads to it needs to be somewhere that can be accessed without roof access. An issue arose with the painting inside Champion's Rest. This painting would ordinarily be okay, but if sunwarp shuffle is on and the Color Hunt sunwarp is not an exit, there is no way to enter Champion's Rest without roof access. This caused generation failures.
This change addresses this edge case by preventing required painting entrances from being in Color Hunt or Champion's Rest under the conditions of vanilla doors and disabled sunwarps or shuffled sunwarps where the Color Hunt sunwarp is not an exit.
How was this tested?
Tested the failing seed, which succeeded. Ran pytest and 50 test generations.
If this makes graphical changes, please attach screenshots.