AHIT: Generation error fixes and some other bug fixes #3663

CookieCat45 · 2024-07-18T05:13:42Z

What is this fixing or adding?

Fixes the following issues:

Impossibly restrictive starts with act shuffle disabled in certain chapters (Battle of the Birds, Alpine)
Snatcher contract locations not having their rules set correctly
Some incorrectly written comparison statements
Time Rifts being placed onto the starting level with act shuffle set to "light"

How was this tested?

Generating several seeds to make sure the issues caused by these bugs no longer occured

If this makes graphical changes, please attach screenshots.

# Conflicts: # worlds/ahit/Regions.py

This reverts commit df58bbc.

This reverts commit 0f4d441.

Exempt-Medic

Changes all LGTM, match my understanding of the game, and fix several failing seeds and other reported errors

alwaysintreble

changes seem fine didn't test anything though

worlds/ahit/__init__.py

Co-authored-by: Aaron Wagener <[email protected]>

NewSoupVi

Small stuff, looks good otherwise

worlds/ahit/__init__.py

…chipelago-ahit into gen-problem-fixes

…3663) * duh * Fuck it * Major fixes * a * b * Even more fixes * New option - NoFreeRoamFinale * a * Hat Logic Fix * Just to be safe * multiworld.random to world.random * KeyError fix * Update .gitignore * Update __init__.py * Zoinks Scoob * ffs * Ruh Roh Raggy, more r-r-r-random bugs! * 0.9b - cleanup + expanded logic difficulty * Update Rules.py * Update Regions.py * AttributeError fix * 0.10b - New Options * 1.0 Preparations * Docs * Docs 2 * Fixes * Update __init__.py * Fixes * variable capture my beloathed * Fixes * a * 10 Seconds logic fix * 1.1 * 1.2 * a * New client * More client changes * 1.3 * Final touch-ups for 1.3 * 1.3.1 * 1.3.3 * Zero Jumps gen error fix * more fixes * Formatting improvements * typo * Update __init__.py * Revert "Update __init__.py" This reverts commit e178a7c. * init * Update to new options API * Missed some * Snatcher Coins fix * Missed some more * some slight touch ups * rewind * a * fix things * Revert "Merge branch 'main' of https://github.com/CookieCat45/Archipelago-ahit" This reverts commit a2360fe, reversing changes made to b8948bc. * Update .gitignore * 1.3.6 * Final touch-ups * Fix client and leftover old options api * Delete setup-ahitclient.py * Update .gitignore * old python version fix * proper warnings for invalid act plandos * Update worlds/ahit/docs/en_A Hat in Time.md Co-authored-by: Danaël V. <[email protected]> * Update worlds/ahit/docs/setup_en.md Co-authored-by: Danaël V. <[email protected]> * 120 char per line * "settings" to "options" * Update DeathWishRules.py * Update worlds/ahit/docs/en_A Hat in Time.md Co-authored-by: Nicholas Saylor <[email protected]> * No more loading the data package * cleanup + act plando fixes * almost forgot * Update Rules.py * a * Update worlds/ahit/Options.py Co-authored-by: Ixrec <[email protected]> * Options stuff * oop * no unnecessary type hints * warn about depot download length in setup guide * Update worlds/ahit/Options.py Co-authored-by: Ixrec <[email protected]> * typo Co-authored-by: Ixrec <[email protected]> * Update worlds/ahit/Rules.py Co-authored-by: Ixrec <[email protected]> * review stuff * More stuff from review * comment * 1.5 Update * link fix? * link fix 2 * Update setup_en.md * Update setup_en.md * Update setup_en.md * Evil * Good fucking lord * Review stuff again + Logic fixes * More review stuff * Even more review stuff - we're almost done * DW review stuff * Finish up review stuff * remove leftover stuff * a * assert item * add A Hat in Time to readme/codeowners files * Fix range options not being corrected properly * 120 chars per line in docs * Update worlds/ahit/Regions.py Co-authored-by: Aaron Wagener <[email protected]> * Update worlds/ahit/DeathWishLocations.py Co-authored-by: Aaron Wagener <[email protected]> * Remove some unnecessary option.class.value * Remove data_version and more option.class.value * Update worlds/ahit/Items.py Co-authored-by: Aaron Wagener <[email protected]> * Remove the rest of option.class.value * Update worlds/ahit/DeathWishLocations.py Co-authored-by: Aaron Wagener <[email protected]> * review stuff * Replace connect_regions with Region.connect * review stuff * Remove unnecessary Optional from LocData * Remove HatType.NONE * Update worlds/ahit/test/TestActs.py Co-authored-by: Aaron Wagener <[email protected]> * fix so default tests actually don't run * Improve performance for death wish rules * rename test file * change test imports * 1000 is probably unnecessary * a * change state.count to state.has * stuff * starting inventory hats fix * shouldn't have done this lol * make ship shape task goal equal to number of tasksanity checks if set to 0 * a * change act shuffle starting acts + logic updates * dumb * option groups + lambda capture cringe + typo * a * b * missing option in groups * c * Fix Your Contract Has Expired being placed on first level when it shouldn't * yche fix * formatting * major logic bug fix for death wish * Update Regions.py * Add missing indirect connections * Fix generation error from chapter 2 start with act shuffle off * a * Revert "a" This reverts commit df58bbc. * Revert "Fix generation error from chapter 2 start with act shuffle off" This reverts commit 0f4d441. * bunch of fixes * Update Regions.py * Update __init__.py * Update __init__.py * Update __init__.py * Update Regions.py * Update worlds/ahit/__init__.py Co-authored-by: Aaron Wagener <[email protected]> * Update __init__.py * Update __init__.py --------- Co-authored-by: Danaël V. <[email protected]> Co-authored-by: Nicholas Saylor <[email protected]> Co-authored-by: Ixrec <[email protected]> Co-authored-by: Aaron Wagener <[email protected]> Co-authored-by: Fabian Dill <[email protected]>

CookieCat45 and others added 30 commits August 27, 2023 18:46

duh

45ccb99

Fuck it

173896b

Major fixes

cbdf4d9

a

5c49cca

b

6442c40

Even more fixes

906c412

New option - NoFreeRoamFinale

1fd2a21

a

b5475ac

Hat Logic Fix

6d9bfbc

Just to be safe

149a42b

multiworld.random to world.random

2b44619

KeyError fix

0dc211f

Update .gitignore

c0adc90

Update __init__.py

e338826

Zoinks Scoob

a7190b6

ffs

a3fd865

Ruh Roh Raggy, more r-r-r-random bugs!

949f152

0.9b - cleanup + expanded logic difficulty

d673b87

Update Rules.py

77ac8a7

Update Regions.py

2ef4422

Merge branch 'ArchipelagoMW:main' into main

127ce1d

AttributeError fix

1f916e8

0.10b - New Options

215594d

1.0 Preparations

1daafff

Docs

02087ed

Docs 2

32561dd

Fixes

6c56f79

Update __init__.py

da20a77

Fixes

c5b8113

variable capture my beloathed

6cedbe8

CookieCat45 and others added 10 commits July 7, 2024 19:48

Merge branch 'ArchipelagoMW:main' into main

8e3845d

Merge branch 'main' of https://github.com/ArchipelagoMW/Archipelago

39b6def

# Conflicts: # worlds/ahit/Regions.py

Fix generation error from chapter 2 start with act shuffle off

0f4d441

Merge branch 'main' of https://github.com/CookieCat45/Archipelago-ahit

3a46b17

a

df58bbc

Revert "a"

a5665bc

This reverts commit df58bbc.

Revert "Fix generation error from chapter 2 start with act shuffle off"

7b1d9eb

This reverts commit 0f4d441.

Merge remote-tracking branch 'upstream/main'

85cad44

bunch of fixes

66e2322

Update Regions.py

eefe461

github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Jul 18, 2024

Update __init__.py

600b382

Exempt-Medic added the is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. label Jul 18, 2024

CookieCat45 added 2 commits July 18, 2024 01:33

Update __init__.py

02d95bd

Update __init__.py

7f9d258

Mysteryem mentioned this pull request Jul 21, 2024

Add game: A Hat in Time ArchipelagoMW/AsyncTools#172

Merged

Exempt-Medic approved these changes Jul 21, 2024

View reviewed changes

Update Regions.py

21ffe63

alwaysintreble approved these changes Jul 24, 2024

View reviewed changes

worlds/ahit/__init__.py Outdated Show resolved Hide resolved

Update worlds/ahit/__init__.py

76937bb

Co-authored-by: Aaron Wagener <[email protected]>

Exempt-Medic added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jul 25, 2024

NewSoupVi requested changes Jul 26, 2024

View reviewed changes

worlds/ahit/__init__.py Outdated Show resolved Hide resolved

worlds/ahit/__init__.py Show resolved Hide resolved

CookieCat45 added 3 commits July 27, 2024 12:58

Update __init__.py

01a8b3f

Merge branch 'gen-problem-fixes' of https://github.com/CookieCat45/Ar…

f203171

…chipelago-ahit into gen-problem-fixes

Update __init__.py

ed443eb

NewSoupVi approved these changes Jul 27, 2024

View reviewed changes

NewSoupVi merged commit e5c9b8a into ArchipelagoMW:main Jul 27, 2024
17 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AHIT: Generation error fixes and some other bug fixes #3663

AHIT: Generation error fixes and some other bug fixes #3663

CookieCat45 commented Jul 18, 2024

Exempt-Medic left a comment

alwaysintreble left a comment

NewSoupVi left a comment

AHIT: Generation error fixes and some other bug fixes #3663

AHIT: Generation error fixes and some other bug fixes #3663

Conversation

CookieCat45 commented Jul 18, 2024

What is this fixing or adding?

How was this tested?

If this makes graphical changes, please attach screenshots.

Exempt-Medic left a comment

Choose a reason for hiding this comment

alwaysintreble left a comment

Choose a reason for hiding this comment

NewSoupVi left a comment

Choose a reason for hiding this comment