Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DLC Quest: Add options presets to DLC Quest #3676

Merged
merged 3 commits into from
Jul 24, 2024
Merged

DLC Quest: Add options presets to DLC Quest #3676

merged 3 commits into from
Jul 24, 2024

Conversation

agilbert1412
Copy link
Collaborator

What is this fixing or adding?

DLC Quest did not have option presets, here are a few. All sane settings, intended for players who are not familiar enough to pick specific things, but want to give it a shot.

How was this tested?

It's just presets

@agilbert1412 agilbert1412 requested review from axe-y and alwaysintreble and removed request for alwaysintreble July 21, 2024 23:50
@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Jul 21, 2024
@agilbert1412 agilbert1412 added is: maintenance Regular updates to requirements and utilities that do not fix bugs or change/add features. waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. labels Jul 21, 2024
@Exempt-Medic Exempt-Medic added is: enhancement Issues requesting new features or pull requests implementing new features. and removed is: maintenance Regular updates to requirements and utilities that do not fix bugs or change/add features. labels Jul 21, 2024
Exempt-Medic
Exempt-Medic approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Merged into main and ran a local WebHost and saw that the presets worked properly

@Exempt-Medic Exempt-Medic removed the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Jul 22, 2024
axe-y
axe-y approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@axe-y axe-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good

@Exempt-Medic Exempt-Medic added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: world-maintainer Issue/PR is waiting for feedback or approval by the maintainer of a world. labels Jul 22, 2024
@NewSoupVi
Copy link
Member

Has conflicts now after merging the option groups PR

@NewSoupVi
Copy link
Member

nvm it's fine

@NewSoupVi NewSoupVi merged commit ff680b2 into ArchipelagoMW:main Jul 24, 2024
17 checks passed
AustinSumigray pushed a commit to AustinSumigray/Archipelago that referenced this pull request Jan 4, 2025
@agilbert1412 @NewSoupVi @AustinSumigray
DLC Quest: Add options presets to DLC Quest (ArchipelagoMW#3676)
40100d5 
* - Add options presets to DLC Quest

* - Removed unused import

---------

Co-authored-by: NewSoupVi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NewSoupVi NewSoupVi NewSoupVi approved these changes

@axe-y axe-y axe-y approved these changes

@Exempt-Medic Exempt-Medic Exempt-Medic approved these changes

Assignees
No one assigned
Labels
is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@agilbert1412 @NewSoupVi @axe-y @Exempt-Medic