DOOM II: Fix sector 95 assignment in DOOM II MAP17 to correctly flag … #3705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the BFG9000 location as in the Yellow Key area
github-actions
bot
added
the
waiting-on: peer-review
KScl
approved these changes
Jul 28, 2024
Exempt-Medic
added
the
waiting-on: world-maintainer
Exempt-Medic
added
the
is: bug/fix
Exempt-Medic
added
the
affects: release/blocker
|
@Daivuk Just a reminder to look at this |
|
@KScl confirmed the change was also made in the tool. So this should be good to go! Approved. |
Daivuk
approved these changes
Sep 17, 2024
Exempt-Medic
added
waiting-on: core-review
NewSoupVi
approved these changes
Sep 17, 2024
AustinSumigray
pushed a commit
to AustinSumigray/Archipelago
that referenced
this pull request
Jan 4, 2025
…the BFG9000 location as in the Yellow Key area (ArchipelagoMW#3705) Co-authored-by: sgrunt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…the BFG9000 location as in the Yellow Key area
What is this fixing or adding?
Related to APDOOM fix Daivuk/apdoom#21, this fixes a logic error in the DOOM II apworld.
How was this tested?
Double checking locally after making the change that granting access to MAP17 does not flag the BFG9000 location as accessible - only after getting access the MAP17 yellow key area (requiring both the red and yellow keys) is the item considered accessible.
If this makes graphical changes, please attach screenshots.
N/A