Core: (CommonClient) Making local datapackage load correctly if it was overriden by a custom one #3722
+23
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
affects: core
qwint
reviewed
Aug 3, 2024
qwint
approved these changes
Aug 3, 2024
There was a problem hiding this comment.
besides my earlier comment on the typo all the code looks fine, (i yearn for a day where we can drop data_version support), ran text client through a debugger and the logic worked fine even with nothing cached, approving assuming the typo gets fixed (because even if it doesn't it's just unneeded calls to remote datapackage not breaking functionality)
NewSoupVi
added
the
is: bug/fix
silasary
approved these changes
Sep 29, 2024
Exempt-Medic
added
the
affects: release/blocker
black-sliver
approved these changes
Oct 16, 2024
AustinSumigray
pushed a commit
to AustinSumigray/Archipelago
that referenced
this pull request
Jan 4, 2025
…iden by a custom one (ArchipelagoMW#3722) * Added versions and checksums dict * Added load of local datapackage * Fixed typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
After joining a game with a datapackage for a given game different to the one in the installed world then joining a room with the same game but the installed datapackage, the cached datapackage isn't updated on CommonClient.
I also made so that the local datapackage could be loaded if it is the right one
How was this tested?
I tried with a modified clique, worked fine.
If this makes graphical changes, please attach screenshots.