kvui: abstract away client tab additions #3950
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Intending for this to get in before #3934, this should allow clients to be cross-compatible between the two client versions. The main (currently-only) failure point for current clients on the KivyMD branch is the swap of GameManager.tabs and what types are accepted its children. As such, this abstracts away this behavior into GameManager itself such that clients need only call the function and provide the content for the tab.
How was this tested?
Loaded up Starcraft 2's client, ensured that tabs worked correctly.
If this makes graphical changes, please attach screenshots.