Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebHost: optimize header-logo.svg #4073

Merged
merged 2 commits into from
Oct 20, 2024

Conversation

black-sliver
Copy link
Member

What is this fixing or adding?

Optimizes the svg for consumption by web browsers.

Technically those files will not produce an identical output when rendered, however the difference is virtually impossible to see even when rendered to w=4096

The original file was copied to a new name because the optimized file breaks the grouping, making it harder to use in an editor.

How was this tested?

Rendering both to png at width=4096 and looking at them.

If this makes graphical changes, please attach screenshots.

The point is not to

technically those files will not produce an identical output when rendered
however the difference is virtually impossible to see even when rendered to w=4096
@github-actions github-actions bot added affects: webhost Issues/PRs that touch webhost and may need additional validation. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Oct 19, 2024
@Exempt-Medic Exempt-Medic added the is: enhancement Issues requesting new features or pull requests implementing new features. label Oct 20, 2024
@black-sliver
Copy link
Member Author

i forfeit any claims of ownership of the images and modifications done here to the extend possible by law and agree the original copyright is unchanged

Copy link
Member

@LegendaryLinux LegendaryLinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Hopefully the site loads faster now.

@LegendaryLinux LegendaryLinux merged commit f709d61 into ArchipelagoMW:main Oct 20, 2024
12 checks passed
@black-sliver black-sliver deleted the optimize-svg branch October 21, 2024 00:01
AustinSumigray pushed a commit to AustinSumigray/Archipelago that referenced this pull request Jan 4, 2025
* WebHost: reduce precision and optimize header-logo.svg

technically those files will not produce an identical output when rendered
however the difference is virtually impossible to see even when rendered to w=4096

* WebHost: keep original svg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: webhost Issues/PRs that touch webhost and may need additional validation. is: enhancement Issues requesting new features or pull requests implementing new features. waiting-on: peer-review Issue/PR has not been reviewed by enough people yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants