Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checksfinder: clean up setup guide intro and change ownership #4147

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

SunCatMC
Copy link
Contributor

@SunCatMC SunCatMC commented Nov 4, 2024

What is this fixing or adding?

Reducing fluff in setup guide intro and changing writer of the guide from mewlif to me (as the stuff from mewlif was basically removed in previous changes)

How was this tested?

by running webhost from source

If this makes graphical changes, please attach screenshots.

image

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Nov 4, 2024
@Exempt-Medic Exempt-Medic added the is: documentation Improvements or additions to documentation. label Nov 4, 2024
Copy link
Member

@Exempt-Medic Exempt-Medic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Exempt-Medic Exempt-Medic added waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Nov 4, 2024
Copy link
Contributor

@nicholassaylor nicholassaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NewSoupVi NewSoupVi merged commit 2bdc1e0 into ArchipelagoMW:main Nov 7, 2024
18 checks passed
AustinSumigray pushed a commit to AustinSumigray/Archipelago that referenced this pull request Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is: documentation Improvements or additions to documentation. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants