-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hubble + Travis = <3 #65
Conversation
woops my bad. i was supposed to send this to my own repo for testing first! my bad. closing. |
No worries. You may just reopen this once you’re done persuading Travis to run without errors 😃. |
OK I think this is ready to go. Nothing but the basic scaffolding for the Python bits, but once we figure out tests for that, shouldn't be too hard to add commands to the travis file to install dependencies and run tests. It looks like Travis is already executing here... so I'm not sure if someone from the project already went and a) logged into Travis with their GitHub account and b) enabled Autodesk/hubble repo to run against Travis - but it looks like it. So yay! Now we get pretty green check marks on the PR list page, or angry red checkmarks if tests fail 😄 |
Oh, I'll also add a Travis badge to the readme. |
… in CI. Set up baseline for future Python testing. Add a Travis badge to the top-level readme.
I was a bit overzealous and turned on Travis as soon as you opened this pull request 😃. And apparently, the first CI build succeeded! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The .travis.yml
looks very good to me, it’s clean and simple.
Let me thank you again—having a working CI setup is a really important matter to us! I’ll give this my approval, and if @larsxschneider doesn’t spot any issue, we’ll merge this pull request tomorrow.
Great, it's been fun working with y'all so far - hope to continue that! I am looking forward to growing and contributing to the Hubble project 😄 |
That sounds great, looking forward to it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fantastic! 🎉 Thank you @filmaj !
No description provided.