A4A: Format currency #100135

yashwin · 2025-02-21T09:52:21Z

Closes https://github.com/Automattic/i18n-issues/issues/921

Related to #

Proposed Changes

Why are these changes being made?

Testing Instructions

Pre-merge Checklist

Has the general commit checklist been followed? (PCYsg-hS-p2)
Have you written new tests for your changes?
Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
Have you checked for TypeScript, React or other console errors?
Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
- For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

github-actions · 2025-02-21T09:52:35Z

Calypso Live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-134098

Jetpack Cloud live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-134098&env=jetpack

Automattic for Agencies live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-134098&env=a8c-for-agencies

yashwin · 2025-02-21T09:58:32Z

client/a8c-for-agencies/sections/referrals/primary/commission-overview/index.tsx

+									" For example, if your client's store generates %(maxAmount)s in TPV per year, your revenue share for that year would be %(amount)s.",
+								{
+									args: {
+										maxAmount: formatCurrency( 1000000, 'USD' ),


Probably we can stick to $1M here?

Interesting! We should probably add a "compact" notation to formatCurrency. Let's stick with $1M and I can follow up on this separately.

cc @sirbrillig / @Automattic/i18n We can just allow formatCurrency to accept numberFormatOptions in the same way numberFormat does, so someone can just tailor the rendering a little better. Or otherwise we can create a numberFormatCompactCurrency abstraction. I'll create an issue.

Thanks!

I think it's better to format this the same way. I did a workaround: bd67c53, a quick hack to get this right. Let me know if this works until we have a function for it. Or we could skip the formatting for this particular section for both $1M and $500.

This is perfect. Thanks! Good use of the currency object parts. Glad to see there is a workaround with the existing APIs :-)

yashwin · 2025-02-21T09:59:05Z

client/a8c-for-agencies/sections/partner-directory/components/budget-selector.tsx

@@ -14,27 +15,39 @@ const BudgetSelector = ( { setBudget, budgetLowerRange }: Props ) => {
 			value: '0',
 		},
 		{
-			label: '$500',
+			label: formatCurrency( 500, 'USD', {


yashwin · 2025-02-21T10:00:26Z

client/a8c-for-agencies/components/a4a-migration-offer-v3/index.tsx

@@ -47,11 +48,16 @@ const MigrationOfferV3 = ( { isExpanded, onToggleView }: Props ) => {
 				<h3 className="a4a-migration-offer-v3__title">
 					<span>
 						{ translate(
-							'{{b}}Limited time offer:{{/b}} Migrate your sites to Pressable or WordPress.com and earn up to $10,000!*',
+							'{{b}}Limited time offer:{{/b}} Migrate your sites to Pressable or WordPress.com and earn up to %(maxCommission)s*',


matticbot · 2025-02-21T10:00:37Z

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

notifications
wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/a4a/format-currency on your sandbox.

matticbot · 2025-02-21T10:02:16Z

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~491 bytes added 📈 [gzipped])

name                                parsed_size           gzip_size
a8c-for-agencies-marketplace             +699 B  (+0.1%)     +188 B  (+0.1%)
a8c-for-agencies-migrations              +524 B  (+0.1%)     +148 B  (+0.1%)
a8c-for-agencies-overview                +523 B  (+0.0%)      +69 B  (+0.0%)
a8c-for-agencies-referrals               +230 B  (+0.0%)      +96 B  (+0.0%)
a8c-for-agencies-partner-directory       +219 B  (+0.0%)      +49 B  (+0.0%)
a8c-for-agencies-client                  +161 B  (+0.0%)      +40 B  (+0.0%)
a8c-for-agencies-agency-tier             +160 B  (+0.1%)      +27 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

chriskmnds

This is awesome. There were quite a few after all 👍

Thanks for spotting all of these cases. I left some comments, and I'll follow up myself on one of them. Thanks for bringing it up.

chriskmnds · 2025-02-21T10:40:18Z

.../hosting-overview-v3/hosting-content/premier-agency-hosting/pressable-plan-section/index.tsx

@@ -245,7 +246,13 @@ export default function PressablePlanSection( {

 				<span className="pressable-plan-section__details-footnote">
 					{ translate(
-						`*If you exceed your plan's storage or traffic limits, you will be charged $0.50 per GB and $8 per 10K visits per month.`
+						`*If you exceed your plan's storage or traffic limits, you will be charged %(storageCharge)s per GB and %(trafficCharge)s per 10K visits per month.`,


per 10K visits

I think let's also pass 10K through numberFormatCompact - it should render as 10 χιλ. in EL/Greek.

chriskmnds · 2025-02-21T10:44:50Z

client/a8c-for-agencies/sections/referrals/primary/commission-overview/index.tsx

+									" For example, if your client's store generates %(maxAmount)s in TPV per year, your revenue share for that year would be %(amount)s.",
+								{
+									args: {
+										maxAmount: formatCurrency( 1000000, 'USD' ),


Interesting! We should probably add a "compact" notation to formatCurrency. Let's stick with $1M and I can follow up on this separately.

cc @sirbrillig / @Automattic/i18n We can just allow formatCurrency to accept numberFormatOptions in the same way numberFormat does, so someone can just tailor the rendering a little better. Or otherwise we can create a numberFormatCompactCurrency abstraction. I'll create an issue.

A4A: Format currency

9d33a9c

yashwin commented Feb 21, 2025

View reviewed changes

chriskmnds reviewed Feb 21, 2025

View reviewed changes

chriskmnds added the i18n: number-format label Feb 21, 2025

more fixes

5be7de0

yashwin force-pushed the update/a4a/format-currency branch from e08e599 to 5be7de0 Compare February 21, 2025 11:10

more formatting

bd67c53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

A4A: Format currency #100135

A4A: Format currency #100135

yashwin commented Feb 21, 2025 •

edited by chriskmnds

Loading

github-actions bot commented Feb 21, 2025 •

edited by matticbot

Loading

yashwin Feb 21, 2025

chriskmnds Feb 21, 2025

yashwin Feb 21, 2025

chriskmnds Feb 21, 2025

yashwin Feb 21, 2025

yashwin Feb 21, 2025 •

edited

Loading

matticbot commented Feb 21, 2025

matticbot commented Feb 21, 2025 •

edited

Loading

chriskmnds left a comment

chriskmnds Feb 21, 2025

chriskmnds Feb 21, 2025

A4A: Format currency #100135

Are you sure you want to change the base?

A4A: Format currency #100135

Conversation

yashwin commented Feb 21, 2025 • edited by chriskmnds Loading

Proposed Changes

Why are these changes being made?

Testing Instructions

Pre-merge Checklist

github-actions bot commented Feb 21, 2025 • edited by matticbot Loading

yashwin Feb 21, 2025

Choose a reason for hiding this comment

chriskmnds Feb 21, 2025

Choose a reason for hiding this comment

yashwin Feb 21, 2025

Choose a reason for hiding this comment

chriskmnds Feb 21, 2025

Choose a reason for hiding this comment

yashwin Feb 21, 2025

Choose a reason for hiding this comment

yashwin Feb 21, 2025 • edited Loading

Choose a reason for hiding this comment

matticbot commented Feb 21, 2025

matticbot commented Feb 21, 2025 • edited Loading

chriskmnds left a comment

Choose a reason for hiding this comment

chriskmnds Feb 21, 2025

Choose a reason for hiding this comment

chriskmnds Feb 21, 2025

Choose a reason for hiding this comment

yashwin commented Feb 21, 2025 •

edited by chriskmnds

Loading

github-actions bot commented Feb 21, 2025 •

edited by matticbot

Loading

yashwin Feb 21, 2025 •

edited

Loading

matticbot commented Feb 21, 2025 •

edited

Loading