-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show a TSP banner for everyone #100165
base: trunk
Are you sure you want to change the base?
Show a TSP banner for everyone #100165
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~2823 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Original issue is
3153-gh-Tumblr/a8c-dsp
Proposed Changes
false
that prevent a TSP banner from being shown for everyoneWhy are these changes being made?
We want to release the Super Native Ad Format (TSP Ads) in WP Blaze for everyone
Testing Instructions
Even though CR is enough,
feel free to create a Jurassic Ninja site, connect it to a non-admin user,
open advertising having
https://wordpress.com/advertising/YOUR-SITE-DOMAIN-NAME
in your address bar,whenever you have TSP eligible posts (read, having Gutenberg blocks), you should see a TSP Banner
Pre-merge Checklist