Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Win32 MonitorFromRect #18285

Merged
merged 1 commit into from
Feb 22, 2025
Merged

Conversation

MrJul
Copy link
Member

@MrJul MrJul commented Feb 21, 2025

What does the pull request do?

This PR fixes our Win32 MonitorFromRect interop signature being incorrect.
Somehow, it doesn't cause a crash for 64 bits processes, but does for 32 bits ones.

@MrJul MrJul added bug os-windows backport-candidate-11.2.x Consider this PR for backporting to 11.2 branch labels Feb 21, 2025
Copy link
Member

@kekekeks kekekeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: it got unnoticed because with x64 calling conventionRECT rc and RECT* rc are the same thing ABI-wise

@MrJul MrJul enabled auto-merge February 21, 2025 23:37
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.3.999-cibuild0055035-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@MrJul MrJul added this pull request to the merge queue Feb 21, 2025
Merged via the queue into AvaloniaUI:master with commit 3ee7102 Feb 22, 2025
11 checks passed
@MrJul MrJul deleted the fix/monitor-from-rect branch February 22, 2025 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-candidate-11.2.x Consider this PR for backporting to 11.2 branch bug os-windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants