Skip to content

Commit

Permalink
fix(playwighttesting): Removed cancellationToken from SetupAsync meth…
Browse files Browse the repository at this point in the history
…od since NUnit does not allow additional params (#46566)

* Removed parameter from SetupAsync method.

* update

* undo last commit

* update

---------

Co-authored-by: guptakashish <[email protected]>
  • Loading branch information
kashish2508 and guptakashish authored Oct 14, 2024
1 parent 98bcb1c commit dcfb2ef
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ public partial class PlaywrightServiceNUnit : Azure.Developer.MicrosoftPlaywrigh
public PlaywrightServiceNUnit(Azure.Core.TokenCredential? credential = null) : base (default(Azure.Developer.MicrosoftPlaywrightTesting.TestLogger.PlaywrightServiceOptions), default(Azure.Core.TokenCredential)) { }
public static Azure.Developer.MicrosoftPlaywrightTesting.TestLogger.PlaywrightServiceOptions playwrightServiceOptions { get { throw null; } }
[NUnit.Framework.OneTimeSetUpAttribute]
public System.Threading.Tasks.Task SetupAsync(System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
public System.Threading.Tasks.Task SetupAsync() { throw null; }
[NUnit.Framework.OneTimeTearDownAttribute]
public void Teardown() { }
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,11 @@ public PlaywrightServiceNUnit(TokenCredential? credential = null)
/// <summary>
/// Setup the resources utilized by Playwright service.
/// </summary>
/// <param name="cancellationToken">Cancellation token.</param>
/// <returns></returns>
[OneTimeSetUp]
public async Task SetupAsync(CancellationToken cancellationToken = default)
public async Task SetupAsync()
{
await InitializeAsync(cancellationToken).ConfigureAwait(false);
await InitializeAsync().ConfigureAwait(false);
}

/// <summary>
Expand Down

0 comments on commit dcfb2ef

Please sign in to comment.