Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deploy pane when deploying .bicep files directly #14587

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Conversation

anthony-c-martin
Copy link
Member

@anthony-c-martin anthony-c-martin commented Jul 18, 2024

As part of the local deployment implementation, I apparently completely removed the ability for the deployment pane to deploy a non-local .bicep file 🤦. This PR fixes that.

The changes in this PR:

  • Fixes deployment through the deploy pane if the user is referencing a .bicep file directly.
  • As part of testing this, I noticed we're actually missing validation for a using statement referencing a broken file. I've updated this to bring it in line with behavior for a module statement referencing a broken file.
  • Fixes the issue where a cryptic error appears in local-deploy mode if the .bicep file is invalid.
  • Fixes an issue where we're not logging the artifact reference properly in error messages (missing a .ToString() implementation).
Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

github-actions bot commented Jul 18, 2024

Test this change out locally with the following install scripts (Action run 9996826574)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 9996826574
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 9996826574"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 9996826574
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 9996826574"

Copy link
Contributor

github-actions bot commented Jul 18, 2024

Dotnet Test Results

    72 files   -     36      72 suites   - 36   23m 42s ⏱️ - 11m 12s
10 966 tests  -     11  10 966 ✅  -     11  0 💤 ±0  0 ❌ ±0 
25 812 runs   - 12 899  25 812 ✅  - 12 899  0 💤 ±0  0 ❌ ±0 

Results for commit 48a4d4f. ± Comparison against base commit f1c7212.

♻️ This comment has been updated with latest results.

@anthony-c-martin anthony-c-martin enabled auto-merge (squash) July 18, 2024 18:21
@anthony-c-martin anthony-c-martin changed the title Fix major regression in the deployment pane Fix deploy pane when deploying .bicep files directly Jul 18, 2024
@anthony-c-martin anthony-c-martin enabled auto-merge (squash) July 18, 2024 18:22
@anthony-c-martin anthony-c-martin merged commit 57a44c0 into main Jul 18, 2024
44 checks passed
@anthony-c-martin anthony-c-martin deleted the ant/deploy branch July 18, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants