Update version #28
Open
Update version #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For docker image compatibility
miguelpmachado
requested review from
cimendes
and removed request for
cimendes
|
Hey @miguelpmachado , why has the argument instrument platform been supressed? |
That information is not longer available through the endpoint we were using |
…ple-data change from counter to dict values
* feat: save reference length * fix: correct reads mapping quality minimum * update version --------- Co-authored-by: Inês Mendes <[email protected]>
Coppini
reviewed
Feb 11, 2025
| programs_version_dictionary['wget'] = ['--version', '>=', '1.12'] | ||
| programs_version_dictionary['gzip'] = ['--version', '>=', '1.6'] | ||
| programs_version_dictionary['wget'] = [None, '>=', '1.12'] | ||
| programs_version_dictionary['gzip'] = [None, '>=', '1.6'] | ||
| programs_version_dictionary['bowtie2'] = ['--version', '>=', '2.2.9'] | ||
| programs_version_dictionary['samtools'] = ['--version', '==', '1.3.1'] |
There was a problem hiding this comment.
Is there a reason for the strict version for samtools/bcftools here? That version is from 2016-04-22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update version for a new release