Jzecm wal local sync 958 #1010
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,118 @@ | ||
| import 'dart:async'; | ||
| import 'dart:math'; | ||
|
|
||
| import 'package:flutter/material.dart'; | ||
| import 'package:friend_private/pages/memories/page.dart'; | ||
| import 'package:friend_private/pages/memories/sync_page.dart'; | ||
| import 'package:friend_private/providers/capture_provider.dart'; | ||
| import 'package:friend_private/providers/developer_mode_provider.dart'; | ||
| import 'package:friend_private/providers/memory_provider.dart'; | ||
| import 'package:friend_private/utils/other/string_utils.dart'; | ||
| import 'package:friend_private/utils/other/temp.dart'; | ||
| import 'package:provider/provider.dart'; | ||
|
|
||
| class LocalSyncWidget extends StatefulWidget { | ||
| const LocalSyncWidget({super.key}); | ||
|
|
||
| @override | ||
| State<LocalSyncWidget> createState() => _LocalSyncWidgetState(); | ||
|
Comment on lines
+15
to
+18
There was a problem hiding this comment.
The - const LocalSyncWidget({super.key});
+ const LocalSyncWidget({Key? key}) : super(key: key); |
||
| } | ||
|
|
||
| enum LocalSyncStatus { | ||
| disabled, | ||
| inProgress, | ||
| flush, // flushed to disk | ||
| } | ||
|
|
||
| class _LocalSyncWidgetState extends State<LocalSyncWidget> { | ||
| LocalSyncStatus? _status; | ||
| Timer? _missSecondsInEstTimer; | ||
| int _missSeconds = 0; | ||
|
|
||
| @override | ||
| void dispose() { | ||
| _missSecondsInEstTimer?.cancel(); | ||
| super.dispose(); | ||
| } | ||
|
Comment on lines
+32
to
+36
There was a problem hiding this comment.
Good practice to cancel timers in the dispose method to prevent memory leaks. |
||
|
|
||
| @override | ||
| Widget build(BuildContext context) { | ||
| return Consumer2<MemoryProvider, CaptureProvider>(builder: (context, provider, captureProvider, child) { | ||
| if (provider.missingWalsInSeconds > 120) { | ||
| _status = LocalSyncStatus.flush; | ||
| _missSeconds = max(_missSeconds, provider.missingWalsInSeconds); // est. good for ux | ||
| } else if (!captureProvider.isWalSupported) { | ||
| _status = LocalSyncStatus.disabled; | ||
| _missSecondsInEstTimer?.cancel(); | ||
| } else if ((!captureProvider.transcriptServiceReady && captureProvider.recordingDeviceServiceReady) || | ||
| provider.missingWalsInSeconds > 0) { | ||
| var previousStatus = _status; | ||
| _status = LocalSyncStatus.inProgress; | ||
|
|
||
| // Change state to in progress | ||
| if (previousStatus != LocalSyncStatus.inProgress) { | ||
| _missSecondsInEstTimer?.cancel(); | ||
| _missSeconds = provider.missingWalsInSeconds; | ||
| _missSecondsInEstTimer = Timer.periodic(const Duration(seconds: 1), (t) { | ||
| setState(() { | ||
| _missSeconds++; | ||
| }); | ||
| }); | ||
| } | ||
| } | ||
|
Comment on lines
+40
to
+62
There was a problem hiding this comment.
The logic for setting - if (provider.missingWalsInSeconds > 120) {
- _status = LocalSyncStatus.flush;
- _missSeconds = max(_missSeconds, provider.missingWalsInSeconds); // est. good for ux
- } else if (!captureProvider.isWalSupported) {
- _status = LocalSyncStatus.disabled;
- _missSecondsInEstTimer?.cancel();
- } else if ((!captureProvider.transcriptServiceReady && captureProvider.recordingDeviceServiceReady) ||
- provider.missingWalsInSeconds > 0) {
- var previousStatus = _status;
- _status = LocalSyncStatus.inProgress;
-
- // Change state to in progress
- if (previousStatus != LocalSyncStatus.inProgress) {
- _missSecondsInEstTimer?.cancel();
- _missSeconds = provider.missingWalsInSeconds;
- _missSecondsInEstTimer = Timer.periodic(const Duration(seconds: 1), (t) {
- setState(() {
- _missSeconds++;
- });
- });
- }
- }
+ _updateStatus(provider, captureProvider);And then define void _updateStatus(MemoryProvider provider, CaptureProvider captureProvider) {
if (provider.missingWalsInSeconds > 120) {
_status = LocalSyncStatus.flush;
_missSeconds = max(_missSeconds, provider.missingWalsInSeconds); // est. good for ux
} else if (!captureProvider.isWalSupported) {
_status = LocalSyncStatus.disabled;
_missSecondsInEstTimer?.cancel();
} else if ((!captureProvider.transcriptServiceReady && captureProvider.recordingDeviceServiceReady) ||
provider.missingWalsInSeconds > 0) {
var previousStatus = _status;
_status = LocalSyncStatus.inProgress;
// Change state to in progress
if (previousStatus != LocalSyncStatus.inProgress) {
_missSecondsInEstTimer?.cancel();
_missSeconds = provider.missingWalsInSeconds;
_startMissSecondsTimer();
}
}
}
void _startMissSecondsTimer() {
_missSecondsInEstTimer = Timer.periodic(const Duration(seconds: 1), (t) {
setState(() {
_missSeconds++;
});
});
} |
||
|
|
||
| // in progress | ||
| if (_status == LocalSyncStatus.inProgress) { | ||
| return Container( | ||
| decoration: BoxDecoration( | ||
| color: Colors.grey.shade900, | ||
| borderRadius: const BorderRadius.all(Radius.circular(12)), | ||
| ), | ||
| margin: const EdgeInsets.fromLTRB(16, 16, 16, 16), | ||
| padding: const EdgeInsets.all(16), | ||
| child: Text( | ||
| '${convertToHHMMSS(_missSeconds)} of conversation locally', | ||
| style: const TextStyle(color: Colors.white, fontSize: 16), | ||
| textAlign: TextAlign.center, | ||
| ), | ||
| ); | ||
| } | ||
|
|
||
| // ready to sync | ||
| if (_status == LocalSyncStatus.flush) { | ||
| return GestureDetector( | ||
| onTap: () { | ||
| routeToPage(context, const SyncPage()); | ||
| }, | ||
| child: Container( | ||
| decoration: BoxDecoration( | ||
| color: Colors.grey.shade900, | ||
| borderRadius: const BorderRadius.all(Radius.circular(12)), | ||
| ), | ||
| margin: const EdgeInsets.fromLTRB(16, 16, 16, 16), | ||
| padding: const EdgeInsets.all(16), | ||
| child: Row( | ||
| mainAxisAlignment: MainAxisAlignment.spaceBetween, | ||
| children: [ | ||
| Expanded( | ||
| child: Row( | ||
| children: [ | ||
| const Icon(Icons.download_rounded), | ||
| const SizedBox(width: 16), | ||
| Text( | ||
| '${secondsToHumanReadable(_missSeconds)} available. Sync now?', | ||
| style: const TextStyle(color: Colors.white, fontSize: 16), | ||
| ), | ||
| ], | ||
| ), | ||
| ), | ||
| ], | ||
| ), | ||
| ), | ||
| ); | ||
| } | ||
|
|
||
| return const SizedBox.shrink(); | ||
| }); | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The setter for
walsis missing null safety checks. If a null list is passed, it will cause aNullPointerExceptionat the map function.