-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user_chat capacity to proactive notification #1441
Conversation
3290ef8
to
c374ed5
Compare
@kodjima33 @beastoin I don't think this implementation is very flexible, because it only allows to add to the llm prompt the AI notifications (from that I understand), so the time sequence is not easy to understand by the llm, and you can't do proper prompt engineering. My PR adds a new webhook that allows the app to save the notifications and then construct the prompt in a more flexible way, in addition to letting the developer log them or save to memory / db. So I don't see the usefulness of this user_chat parameter, and also why is it called user_chat if it contains AI messages? It would make sense for user_chat to mean written chat messages as opposed to audio transcripts, and there should be a separate webhook for that. |
this implementation is not about the flexibility. it's all about adding support new capacity to the current proactive notification infra - developers now could access Omi's user chats through the prompt template by simply using the parameter {{user_chat}}. man, what plugin have you created ? if you don't have one yet, my suggestion is to either read more about the code or just go ahead and create one. i appreciate your PR. but i am confused - do you want to hear my suggestion for your PR or not ? https://discord.com/channels/1192313062041067520/1311842044259598406 https://discord.com/channels/1192313062041067520/1307242485264810044 |
@beastoin yes I am interested in your suggestions, but I pushed my PR with urgency bacause @kodjima33 said it was urgent. I was not able to test it properly though, due to issues setting up the dev environment, but if there is some bug the code can be tested and reviewed nonetheless. I don't understand why you are writing like I don't understand the issue, without addressing the technical points I made in my messages here and in the PR. You could have replied to my technical points one by one, or made comments in my PR. Yes, I have created my own app based on mentor, and submitted it for the hackaton, and plan to improve it as time allows. I think your PR is still useful as a simpler way for developers to use in simple cases, but it does not fully address #1327 in my opinion. I have also made a suggestion for direct notifications from apps here: #1434 I added it here: https://discord.com/channels/1192313062041067520/1314242481365192789 |
my suggestion: for your concerns:
please help me address your understanding about the stakeholder needs at #1327 and how you fulfill that needs with your PR.
it's not about the technical man.
tell me more about your app. is it work ? what problem would it solve ? are there any technical limitation with the current Omi Apps infra and why. @tiagoefreitas direct notifications should be supported soon and i would be super happy if you could try to make it happen. |
Issue: #1327
Usages
Enable the user_chat (User chat) notification scope via Omi App
Put

{{user_chat}}
into your prompt templateResponse 'user_chat' as a param in the
params
field, e.g.Example:
TODO
Deploy steps