Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat Fixes and Improvements #1484

Merged
merged 2 commits into from
Dec 7, 2024
Merged

Chat Fixes and Improvements #1484

merged 2 commits into from
Dec 7, 2024

Conversation

mdmohsin7
Copy link
Collaborator

@mdmohsin7 mdmohsin7 commented Dec 5, 2024

Part of #1414

  • There are no user sent messages for the omi app if I close and open the main app
  • Apps send two initial messages instead of one

@mdmohsin7 mdmohsin7 marked this pull request as ready for review December 5, 2024 13:33
@beastoin
Copy link
Collaborator

beastoin commented Dec 7, 2024

lgtm @mdmohsin7 🥳

also what is the root cause of null, no_select ? 🫢

@beastoin beastoin merged commit c05405a into main Dec 7, 2024
@beastoin beastoin deleted the chat-changes branch December 7, 2024 08:18
@mdmohsin7
Copy link
Collaborator Author

The issue was that when no plugin id was being passed, the backend was receiving "null" (string) as the plugin_id and it was storing the same in firestore. So when you try to fetch messages from the db it will try to fetch all the messages with plugin_id value as null, but the user sent messages have the value "null", hence they were never returned by the db @beastoin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants