Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: better error message when iOS version requested not present #64

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brainbicycle
Copy link

@brainbicycle brainbicycle commented Nov 21, 2023

thanks for the orb!

Adds a slightly more helpful error message in the event that the requested iOS version is not installed on the ci machine. Used the function that already exists for a similar purpose as a guideline.

job here failed due to requesting 17.0 when not available: https://app.circleci.com/pipelines/github/artsy/eigen/48271/workflows/cb429968-2f28-4859-bb6e-f54227923dcf/jobs/165451
with error:

jq: error (at <stdin>:2499): Cannot iterate over null (null)
Exited with code exit status 5

instead fail with something like:

ERROR!: Simulator runtime not found
Requested: Simulator Runtime: iOS-18-3
Available Runtimes:
com.apple.CoreSimulator.SimRuntime.iOS-12-4
com.apple.CoreSimulator.SimRuntime.iOS-13-7
com.apple.CoreSimulator.SimRuntime.iOS-14-2
com.apple.CoreSimulator.SimRuntime.iOS-16-4

@brainbicycle brainbicycle requested a review from a team as a code owner November 21, 2023 19:11
@brainbicycle
Copy link
Author

@BytesGuy sorry for ping but I can't assign reviewers so thought it may have been missed

@bdellegrazie
Copy link
Contributor

@brainbicycle just FYI, I believe you can close this PR as they have implemented something similar but in a slightly different way.

@brainbicycle
Copy link
Author

alright thanks for the update!

@brainbicycle brainbicycle deleted the brian/preboot-sim-error branch April 10, 2024 01:41
@brainbicycle brainbicycle restored the brian/preboot-sim-error branch November 22, 2024 21:13
@brainbicycle
Copy link
Author

hmmm this error message is still pretty opaque unless I am missing something: https://app.circleci.com/pipelines/github/artsy/eigen/62319/workflows/578f31e5-af6f-4c4c-a504-5b6f6c4ab39c/jobs/215539

@brainbicycle brainbicycle reopened this Nov 22, 2024
@stianjensen
Copy link

hmmm this error message is still pretty opaque unless I am missing something: https://app.circleci.com/pipelines/github/artsy/eigen/62319/workflows/578f31e5-af6f-4c4c-a504-5b6f6c4ab39c/jobs/215539

Agreed, observing the same now while trying to update to Xcode 16. Would be very helpful with some information on which version is not available, and what versions actually are. Found this PR while googling the cryptic error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants