Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QAbstractScrollArea padding clips text #159

Closed
SomberNight opened this issue May 5, 2019 · 5 comments
Closed

QAbstractScrollArea padding clips text #159

SomberNight opened this issue May 5, 2019 · 5 comments
Assignees
Labels
Milestone

Comments

@SomberNight
Copy link

Using QDarkStyle 2.6.8, PyQt 5.11.3, cpython 3.6.6, on Windows 10.

Text is getting clipped in this QPlainTextEdit:
img1
Text also getting clipped here. Not sure what Qt element it is, it belongs to a QCompleter.
img2

Issue does not affect QDarkStyle 2.5.4, on the same system.

Also tested on Ubuntu 18.04 (with GNOME), PyQt 5.11.3, cpython 3.6.7.
There is less clipping there but still some.
img3


I've tracked this down; and it is because of the padding of QAbstractScrollArea:

QAbstractScrollArea {
background-color: #19232D;
border: 1px solid #32414B;
border-radius: 4px;
padding: 4px;

@goanpeca
Copy link
Collaborator

goanpeca commented May 6, 2019

Maybe we need to add a minimum height and still have padding?

Something like:

 QAbstractScrollArea { 
   background-color: #19232D; 
   border: 1px solid #32414B; 
   border-radius: 4px; 
   padding: 4px;
   min-height: 1.5em;
...

@dpizetta
Copy link
Collaborator

dpizetta commented May 6, 2019

@SomberNight is this happening on older versions? Like 2.6.7, 2.6.6... Tks

@SomberNight
Copy link
Author

@dpizetta Yes, it happens with all of 2.6.5, 2.6.6, 2.6.7

cculianu added a commit to Electron-Cash/Electron-Cash that referenced this issue May 7, 2019
- In wallet.py, finding a default label was iterating over an object
that is shared with the network thread (self.txo). This caused #1328 go
boom.

- Additionally, this commit has a fix to the QDarkStyle >=2.6.8 where
things looks too squashed in some of the line edits. See
ColinDuquesnoy/QDarkStyleSheet#159

Partially taken from spesmilo 00b2fee
cculianu added a commit to simpleledger/Electron-Cash-SLP that referenced this issue May 12, 2019
… too squashed

- In wallet.py, finding a default label was iterating over an object
that is shared with the network thread (self.txo). This caused Electron-Cash#1328 go
boom.

- Additionally, this commit has a fix to the QDarkStyle >=2.6.8 where
things looks too squashed in some of the line edits. See
ColinDuquesnoy/QDarkStyleSheet#159

Partially taken from spesmilo 00b2fee
@dpizetta dpizetta self-assigned this May 24, 2019
@dpizetta dpizetta added the bug label May 24, 2019
@dpizetta dpizetta added this to the 2.7 milestone May 24, 2019
@dpizetta
Copy link
Collaborator

dpizetta commented Jun 1, 2019

@SomberNight could you try this commit using 2px? Changing to 0px generate problems in the example also using min-height. Tks

@SomberNight
Copy link
Author

I've tested with version 2.7 from PyPI. Seems to work. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants