Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors in README #87

Merged
merged 2 commits into from
Mar 26, 2018
Merged

Fix errors in README #87

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
957166a
Fixed stylesheet resource path in example code
Mar 13, 2018
193ac81
Fix broken link
Mar 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
[![Latest PyPI version](https://img.shields.io/pypi/v/QDarkStyle.svg)](https://pypi.python.org/pypi/QDarkStyle)
[![License: MIT](https://img.shields.io/dub/l/vibe-d.svg)](https://opensource.org/licenses/MIT)
[![License: CC BY 4.0](https://img.shields.io/badge/License-CC%20BY%204.0-lightgrey.svg)](https://creativecommons.org/licenses/by/4.0/)
[![conduct](https://img.shields.io/badge/code%20of%20conduct-contributor%20covenant-green.svg?style=flat-square)][http://contributor-covenant.org/version/1/4/]
[![conduct](https://img.shields.io/badge/code%20of%20conduct-contributor%20covenant-green.svg?style=flat-square)](http://contributor-covenant.org/version/1/4/)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!



A dark stylesheet for Qt applications (Qt4, Qt5, PySide, PyQt4, PyQt5, QtPy,
Expand Down Expand Up @@ -47,7 +47,7 @@ From code: Download/clone the project, go to ``qdarkstyle`` folder then:
- Load the stylesheet:

```cpp
QFile f("qdarkstyle/style.qss");
QFile f(":qdarkstyle/style.qss");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not so familiar with Qt in C++, but some user has sent me an email saying that it did not work with ":". I've read something about it and they didn't use ":". There is a link for examples of QFile. At this moment I don't have an environment to test. Can you bring more info about it?

I commonly don't use ":" when referring to a real file, i.e resource file. I used ":" just when referring a prefix inside a resource file.

resource_path = "../../icons/resource.qrc"
icon_path = ":/resource_prefix/sub_prefix/image_name.ext"

Thanks for your contribution :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC I added it as a resource, and for it to work I had to add ':'. See here. It's for accessing resources, if you are accessing a real file, as you said, you don't need it.

I thought that the second step in the README meant adding the file as a resource, and I needed to add the ':' for it to work that way. Thought it was missing, so I sent a PR 😊

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aleksasteam You're right. The second step in the README meant adding the file as a resource. The missing : is a typo and is really needed.

@dpizetta FYI the : is not specific to C++, we use it to load the stylesheet with python as well.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aleksasteam thanks again! @ColinDuquesnoy thanks for the information.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some references for the registry:
http://thisthread.blogspot.com.br/2011/04/accessing-file-as-resource.html
http://doc.qt.io/archives/vs-addin/vs-addin-managing-resources.html
http://doc.qt.io/qt-5/resources.html

if (!f.exists())
{
printf("Unable to set stylesheet, file not found\n");
Expand Down